Draft
Conversation
- dead function - memory leaks, most but not all in error paths - uninit memory use, including free(wild) in error paths - int/unsigned conflicts that theoretically can lead to loop over max_uint.
Collaborator
Author
|
this needs test input that runs valgrind clean before merging. |
Collaborator
|
@baallan, I would like to convert this sampler to take a JSON configuration file to allow for more convenient configuration. Currently, it has a very long configuration string with a bunch of hard to understand (without reading the code). |
Collaborator
Author
|
@tom95858 fine by me, but maybe consider yaml instead of json? |
Collaborator
|
@baallan, yeah that makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.