Fix holding value calculation - #103
Open
rsahwe wants to merge 11 commits into
Open
Conversation
Missing: prestige sale, coin transfers and rug pull notification minimum
Author
|
If not then this is ready |
rsahwe
marked this pull request as ready for review
June 27, 2025 18:53
Author
|
When is this reviewed? @face-hh |
He isn't super active 🤷 |
Author
|
So will this be merged or not? |
Member
|
The code is repeating, it would be better to have a function in lib/ to use. There's also other places where this has to be fixed. |
Author
|
Now the question is if transfers should use this (also prestige still needs to be fixed #102) |
Author
|
I am just going to include transfers in this |
Author
|
The client side for coin transfers is still not updated (and since the AMMSell values are lower this is a problem). |
Author
|
I would appreciate it if you fix this instead since I don't know much about this kind of server/client interaction with svelte. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing: prestige sale, coin transfers and rug pull notification minimum
#90
This calculates the value of a holding through AMM sale instead of
quantity * priceCurrently waiting on #102 and on the question if coin transfers should calculate the value the same way.