Support for AMD ROCm compatible GPUs.#559
Open
cupertinomiranda wants to merge 1 commit intoostris:mainfrom
Open
Support for AMD ROCm compatible GPUs.#559cupertinomiranda wants to merge 1 commit intoostris:mainfrom
cupertinomiranda wants to merge 1 commit intoostris:mainfrom
Conversation
|
No plan at windows radeon support? |
cupertinomiranda
force-pushed
the
main
branch
from
4ee414d to
6a52af4
Compare
Author
If by Radeon support you mean any card that has ROCm support, then the answer is yes. However, I will need some time to setup a windows environment to try it. It would be nice if someone with a Windows setup could contribute it, considering that it could be a very easy patch. It works with other low end cards as well. It is in no way limited to the AI PRO R9700. |
ptelder
reviewed
Dec 7, 2025
|
|
||
| async function getAMDGpuStats(isWindows: boolean) { | ||
| // Execute command | ||
| const command = 'amd-smi static --json && echo ";" && amd-smi metric --json'; |
There was a problem hiding this comment.
This command will fail on systems with an inactive AMD iGPU in addition to an AMD discrete GPU.
The amd-smi metric JSON returns an empty usage attribute in gpu_data for an inactive iGPU looking like:
"usage": "N/A",
|
There's an issue for systems with an inactive iGPU on line 147 of ui/src/app/api/gpu/route.ts. The JSON returned for an inactive iGPU has an empty usage attribute. Here's what the first chunk of an iGPU looks like: The missing data kills the parsing and prevents other GPUs from being detected. |
Author
|
Thanks for the comment. Will change the patch with a renewed improved version. |
cupertinomiranda
force-pushed
the
main
branch
2 times, most recently
from
3c65577 to
b75d940
Compare
|
Update, latest bitsandbytes packages now include rocm support. I was able to run with it and your changes. |
|
After manually editing all the changes, I get an error like this when I define a new job. I couldn’t understand what the problem is.
|
|
@cupertinomiranda Thank you for putting this together! Unfortunately, I could not get it to work. After completing the build and running the UI, it fails like so: 
With this repeating in the console: Would you be so kind as to contribute a Dockerfile for ROCm? I have the same PRO 9700 XT card as you. |
Author
Sorry, but that is not my territory, would not know where to start. |
cupertinomiranda
force-pushed
the
main
branch
2 times, most recently
from
8fa5eba to
53e91ee
Compare
cupertinomiranda
force-pushed
the
main
branch
from
53e91ee to
9aeb17f
Compare
Author
|
This is a pull request, not an issue, or a reddit post. Please! If you have any solutions, contribute them as a pull request on my own forked repo. |
Sorry, I didn't mean this to befome a support section, I merely provided feedback for the PR because for me, it doesn't work out of the box due to "amd-smi" issues with current instructions, and I just wanted the issue to not be present when it's merged, as other users may encounter it after it's merged and then have to burden ai-toolkit devs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support for AMD ROCm capable GPUs to the project, for Linux at the moment.
Hope you find the implementation sane and complete.
I have been using it for the last couple of days with great success.