ort-project-file: Fix the fallback for the project name#11591
Merged
Conversation
Use the same order as in the constructors signature. Signed-off-by: Frank Viernau <frank.viernau@gmail.com>
plugins/package-managers/ort-project-file/src/main/kotlin/OrtProjectMapper.kt
Outdated
Show resolved
Hide resolved
If `projectName` is not specified a default project name is used. This can easily lead to analyzer issues caused by duplicate identifiers, in case multiple ORT project files are used. Make use of `getFallbackProjectName()` to make the implementation consistent with other package managers, and to ensure identifiers are unique. Signed-off-by: Frank Viernau <frank.viernau@gmail.com>
fviernau
force-pushed
the
ort-project-file-fallback-project-name
branch
from
a111a13 to
e59f8d3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11591 +/- ##
=========================================
Coverage 58.40% 58.40%
Complexity 1758 1758
=========================================
Files 355 355
Lines 13219 13219
Branches 1314 1314
=========================================
Hits 7721 7721
Misses 5008 5008
Partials 490 490
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mnonnenmacher
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.