fix(gradle): Avoid ConcurrentModificationException in init script#11589
Draft
Juli0q wants to merge 1 commit intooss-review-toolkit:mainfrom
Draft
fix(gradle): Avoid ConcurrentModificationException in init script#11589Juli0q wants to merge 1 commit intooss-review-toolkit:mainfrom
Juli0q wants to merge 1 commit intooss-review-toolkit:mainfrom
Conversation
Take snapshots of `project.configurations` and `project.repositories` with `.toList()` before iterating over them. These are live Gradle collections, and dependency resolution can trigger changes to them while the model is built, causing a ConcurrentModificationException with Gradle 9.3.1. Signed-off-by: Julian Olderdissen <julian.olderdissen@bosch.com>
Juli0q
force-pushed
the
fix/gradle-concurrent-modification
branch
from
8494857 to
81a59c2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11589 +/- ##
============================================
+ Coverage 58.38% 58.99% +0.61%
- Complexity 1753 1799 +46
============================================
Files 355 355
Lines 13210 13416 +206
Branches 1313 1368 +55
============================================
+ Hits 7712 7915 +203
+ Misses 5008 5005 -3
- Partials 490 496 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fviernau
reviewed
Mar 20, 2026
| } | ||
|
|
||
| List<OrtConfiguration> configurations = project.configurations.findResults { configuration -> | ||
| List<OrtConfiguration> configurations = project.configurations.toList().findResults { configuration -> |
Member
There was a problem hiding this comment.
commit-message: Can you describe how frequent (percentage) the issues reproduces? Also, is this really preventing it, or is just the likelyhood reduced?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take snapshots of
project.configurationsandproject.repositorieswith.toList()before iterating over them. These are live Gradle collections, and dependency resolution can trigger changes to them while the model is built, causing a ConcurrentModificationException with Gradle 9.3.1.I've tested with the existing Gradle version functional tests. The test passed and covers all supported Gradle versions, including Gradle 9.3.1.