Null checks for allocations in MKL backend to prevent crashes under memory pressure#780
Open
jberg5 wants to merge 2 commits into
Open
Null checks for allocations in MKL backend to prevent crashes under memory pressure#780jberg5 wants to merge 2 commits into
jberg5 wants to merge 2 commits into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#779
I've observed segfaults when running (python) OSQP in a memory constrained production environment. It appears that when the system is under memory pressure, and allocations fail, there are a few areas in the code where the failures go unchecked and cause serious issues.
This PR attempts to address them. To contain the scope, I've only tried to fix the MKL backend here. If this approach seems reasonable I can try to fix the builtin backend as well.
Claude (with Opus 4.6) wrote most of this under my direction.