Integrate mlflow tracking for sklearn based tasks#151
Open
lorenzomammana wants to merge 7 commits intomainfrom
Open
Integrate mlflow tracking for sklearn based tasks#151lorenzomammana wants to merge 7 commits intomainfrom
lorenzomammana wants to merge 7 commits intomainfrom
Conversation
…ing of sklearn classification models
There was a problem hiding this comment.
Pull request overview
This pull request integrates MLflow tracking capabilities for sklearn-based classification tasks, extending existing MLflow support beyond PyTorch Lightning workflows.
Changes:
- Refactored MLflow artifact uploading logic from
utils.pyinto a dedicatedmlflow.pymodule - Implemented
SklearnMLflowClientand mixin classes for sklearn task tracking - Added MLflow logging hooks to sklearn classification and patch classification tasks
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| quadra/utils/utils.py | Removed deprecated finish() function and related imports after moving MLflow logic to dedicated module |
| quadra/utils/mlflow.py | Added sklearn MLflow client, mixins, and helper functions; refactored Lightning artifact upload logic |
| quadra/tasks/base.py | Updated to call new upload_lightning_artifacts() instead of deprecated finish() |
| quadra/tasks/classification.py | Integrated SklearnClassificationMLflowMixin and added MLflow logging lifecycle hooks |
| quadra/tasks/patch.py | Integrated SklearnPatchMLflowMixin and added MLflow logging lifecycle hooks |
| quadra/tasks/segmentation.py | Added .cpu() calls to prevent GPU memory accumulation during test data collection |
| quadra/datamodules/segmentation.py | Added progress bar for split file reading; corrected docstring default value |
| quadra/configs/experiment/base/classification/sklearn_classification.yaml | Added MLflow logger configuration and artifact upload settings |
| quadra/configs/experiment/base/classification/sklearn_classification_patch.yaml | Added MLflow logger configuration and artifact upload settings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| """Upload config files to MLFlow server. | ||
|
|
||
| Args: | ||
| config: Configuration composed by Hydra.. |
There was a problem hiding this comment.
Corrected double period '..' to single period '.' in docstring
Suggested change
| config: Configuration composed by Hydra.. | |
| config: Configuration composed by Hydra. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Checklist
Please confirm that the following tasks have been completed: