feat: add --no-text flag to conditionally disable text overlays on map posters#229
Open
fasaya wants to merge 1 commit intooriginalankur:mainfrom
Open
feat: add --no-text flag to conditionally disable text overlays on map posters#229fasaya wants to merge 1 commit intooriginalankur:mainfrom
fasaya wants to merge 1 commit intooriginalankur:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new --no-text command-line argument that allows users to generate map posters without any embedded text overlays. By default, maps are generated with the city, country, coordinates, and attribution text, but in some scenarios (e.g., when users want to use the maps as clean backgrounds or apply custom text in post-processing), a completely textless variant is preferred.
Changes Made:
How to Test: Run the following command to generate a map without the text overlays:
Verify that the output poster does not contain the city name, country name, coordinates, divider line, or bottom-right attribution, but correctly outputs the map and border layout. Alternatively, you can run the test/all_variations.sh script to verify it fits nicely alongside existing tests.
This is the result example for Tokyo, Japan
![Uploading tokyo_neon_cyberpunk_20260417_104542.png…]()