Skip to content

a few things...#199

Merged
orhun merged 7 commits intoorhun:mainfrom
tessus:a-few-things
Sep 19, 2025
Merged

a few things...#199
orhun merged 7 commits intoorhun:mainfrom
tessus:a-few-things

Conversation

@tessus
Copy link
Contributor

@tessus tessus commented Sep 9, 2025

Description

This PR includes a few commits:

chore: add git cliff config file
docs(changelog): fix link and heading level
docs(readme): fix example and help, update copyright year
chore(deps): update several deps
chore(ci): update external actions
chore(ci): replace unmaintained actions
fix(docker): make keywords uppercase

Motivation and Context

  • fix the lychee step in pipeline
  • make future updates to the changelog easier
  • close all dependabot PRs

closes #148, #157, #162, #174, #175, #194, #195, #198, #200, #202

How Has This Been Tested?

cargo test

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other: CI

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tessus tessus requested a review from orhun as a code owner September 9, 2025 00:40
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.68%. Comparing base (95ded6c) to head (77b0971).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
- Coverage   80.84%   80.68%   -0.15%     
==========================================
  Files          22       22              
  Lines        1518     1516       -2     
==========================================
- Hits         1227     1223       -4     
- Misses        291      293       +2     
Flag Coverage Δ
unit-tests 80.68% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tessus
Copy link
Contributor Author

tessus commented Sep 9, 2025

Not sure what's up with the thiserror problem in the pipeline. I could run all tests locally and cargo clippy also didn't show an error.

I'll have to investigate. If you have an idea, please let me know.

P.S.: I created an issue dtolnay/thiserror#432

@tessus
Copy link
Contributor Author

tessus commented Sep 9, 2025

It seems we have to replace the deprecated action-rs actions. I'll try that tomorrow.

@orhun
Copy link
Owner

orhun commented Sep 9, 2025

Thanks for the PR!

regarding 84acbc6 - I think that should be fixed in https://github.com/orhun/git-cliff/blob/main/examples/github-keepachangelog.toml as well

I'll have to investigate. If you have an idea, please let me know.

I have definitely seen that before. I think we can apply David's suggestion there.

@tessus
Copy link
Contributor Author

tessus commented Sep 9, 2025

regarding 84acbc6 - I think that should be fixed in https://github.com/orhun/git-cliff/blob/main/examples/github-keepachangelog.toml as well

I will create a PR tomorrow.

I think we can apply David's suggestion there.

Yes, I remember I replaced deprecated actions in rustypaste and rustypaste-cli.
I'll make the same changes here. Tomorrow that is. Now I need my beauty sleep. ;-)

@tessus
Copy link
Contributor Author

tessus commented Sep 10, 2025

Ha, this is funny. Now some of the jobs failed again.

I believe that while replacing the deprecated and unmainained actions was a good idea anyway, this has nothing to do with them.

As you can see the previous run succeeded: https://github.com/orhun/systeroid/actions/runs/17598496376

Then the next run failed, even they use the same cross images. I suspect that if you were to re-run the ci again in a few hours, it would succeed again.

@orhun
Copy link
Owner

orhun commented Sep 11, 2025

I just re-ran the CI

@tessus
Copy link
Contributor Author

tessus commented Sep 11, 2025

I just re-ran the CI

thanks. as you can see it ran through and succeeded. there must be an issue with the runners. weird. not sure how to tackle this.

@tessus
Copy link
Contributor Author

tessus commented Sep 18, 2025

Ok, updated the cliff.toml with your change and squashed 2 related commits.

@tessus
Copy link
Contributor Author

tessus commented Sep 18, 2025

I think this is ready.

These commits should probably not be squashed, since they are not really related. But it's up to you.

The failing jobs are inconsistent and intermittent. If you rerun them again tomorrow, they will most likely pass. As I've mentioned before, something is off with the gh runners.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@orhun orhun merged commit 86035f9 into orhun:main Sep 19, 2025
9 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants