Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
==========================================
- Coverage 80.84% 80.68% -0.15%
==========================================
Files 22 22
Lines 1518 1516 -2
==========================================
- Hits 1227 1223 -4
- Misses 291 293 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Not sure what's up with the I'll have to investigate. If you have an idea, please let me know. P.S.: I created an issue dtolnay/thiserror#432 |
|
It seems we have to replace the deprecated |
|
Thanks for the PR! regarding 84acbc6 - I think that should be fixed in https://github.com/orhun/git-cliff/blob/main/examples/github-keepachangelog.toml as well
I have definitely seen that before. I think we can apply David's suggestion there. |
I will create a PR tomorrow.
Yes, I remember I replaced deprecated actions in rustypaste and rustypaste-cli. |
|
Ha, this is funny. Now some of the jobs failed again. I believe that while replacing the deprecated and unmainained actions was a good idea anyway, this has nothing to do with them. As you can see the previous run succeeded: https://github.com/orhun/systeroid/actions/runs/17598496376 Then the next run failed, even they use the same cross images. I suspect that if you were to re-run the ci again in a few hours, it would succeed again. |
|
I just re-ran the CI |
thanks. as you can see it ran through and succeeded. there must be an issue with the runners. weird. not sure how to tackle this. |
a002c5d to
7d92ea5
Compare
7d92ea5 to
c97e4c8
Compare
|
Ok, updated the cliff.toml with your change and squashed 2 related commits. |
chore(ci): conditional cross compilation
The 'as' keyword should match the case of the 'from' keyword FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/
c97e4c8 to
77b0971
Compare
|
I think this is ready. These commits should probably not be squashed, since they are not really related. But it's up to you. The failing jobs are inconsistent and intermittent. If you rerun them again tomorrow, they will most likely pass. As I've mentioned before, something is off with the gh runners. |
Description
This PR includes a few commits:
Motivation and Context
closes #148, #157, #162, #174, #175, #194, #195, #198, #200, #202
How Has This Been Tested?
cargo test
Screenshots / Logs (if applicable)
Types of Changes
Checklist: