feat(cli): honor XDG_CONFIG_HOME on macOS#1259
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1259 +/- ##
==========================================
- Coverage 43.65% 43.31% -0.33%
==========================================
Files 22 22
Lines 1982 1986 +4
==========================================
- Hits 865 860 -5
- Misses 1117 1126 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I don't have rust nightly installed, thus I cannot format the code. It's the first time I have seen that a project uses nightly to check the formatting. Isn't this a bit fragile? Either way, I can install nightly later today or maybe you can format it if you have it installed. |
orhun
left a comment
There was a problem hiding this comment.
Looking pretty good! Just some minor points
|
Yeah, you can format via |
|
There is some discussion about nightly in #1184 It's not that breaking, unless you're switching to a new edition btw. |
Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
Hmmm, nope: Anyway, when I ran it, much less was fixed than what was shown in the pipeline. Let's see, if it now runs through. P.S.: Switching is not necessary, but now it will download the nightly almost every time I use |
|
Nice, the formatting seems ok. Issues with link validation are not related to this PR. So we should be good. |
Description
git-cliff ignores the
XDG_CONFIG_HOMEenv var on macOS and only considersLibrary/Application Supportas the config dir, which is primarily used by GUI apps.This change allows the default config file to be placed in the following 3 locations on macOS:
XDG_CONFIG_HOME/git-cliff/cliff.toml~/.config/git-cliff/cliff.toml~/Library/Application Support/git-cliff/cliff.tomlThe first one found is used.
Motivation and Context
see #1249 (comment)
How Has This Been Tested?
manually and with debug output
Screenshots / Logs (if applicable)
Types of Changes
Checklist: