fix: route push completion output through logger - #249
Merged
Conversation
Contributor
|
This looks good @tomatotomata - a simple and reasonable change. Please see the DCO requirements here: https://github.com/oras-project/oras-py/pull/249/checks?check_run_id=92784221176 |
Signed-off-by: ahmad <ahmadalgaidy@hotmail.com>
tomatotomata
force-pushed
the
codex/push-quiet-output
branch
from
August 8, 2026 13:48
d4bd814 to
1634cdc
Compare
Contributor
Author
|
The DCO check was the only action-required gate. I amended the head commit with the authorized sign-off |
vsoch
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Registry.push()now routes its completion message through the existing logger instead of writing directly to stdout. It also accepts the documentedquietoption, so callers such asexamples/simple/push.pycan suppress that message without aTypeError.Why
The direct
print()made it impossible to pipe a digest or other command output cleanly. This keeps informational output on the logger path and preserves the completion message by default.Validation
python -m pytest -p no:recording oras/tests/test_provider.py -k 'quiet_output or quiet_suppresses' -qpassed: 2 testspython -m compileall -q oraspassedpython -m isort --check-only oras/provider.py oras/tests/test_provider.pypassedgit diff --checkpassedtest_sanitize_pathcaused by Windows path separator expectationsThis addresses #229. I used an AI coding assistant during implementation and reviewed the resulting diff and test evidence locally.