Skip to content

fix: route push completion output through logger - #249

Merged
vsoch merged 1 commit into
oras-project:mainfrom
tomatotomata:codex/push-quiet-output
Aug 8, 2026
Merged

fix: route push completion output through logger#249
vsoch merged 1 commit into
oras-project:mainfrom
tomatotomata:codex/push-quiet-output

Conversation

@tomatotomata

Copy link
Copy Markdown
Contributor

What changed

Registry.push() now routes its completion message through the existing logger instead of writing directly to stdout. It also accepts the documented quiet option, so callers such as examples/simple/push.py can suppress that message without a TypeError.

Why

The direct print() made it impossible to pipe a digest or other command output cleanly. This keeps informational output on the logger path and preserves the completion message by default.

Validation

  • python -m pytest -p no:recording oras/tests/test_provider.py -k 'quiet_output or quiet_suppresses' -q passed: 2 tests
  • python -m compileall -q oras passed
  • python -m isort --check-only oras/provider.py oras/tests/test_provider.py passed
  • git diff --check passed
  • Full suite: 54 passed, 19 skipped, 1 unrelated baseline failure in test_sanitize_path caused by Windows path separator expectations

This addresses #229. I used an AI coding assistant during implementation and reviewed the resulting diff and test evidence locally.

@tomatotomata
tomatotomata requested a review from vsoch as a code owner August 7, 2026 05:56
@vsoch

vsoch commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

This looks good @tomatotomata - a simple and reasonable change. Please see the DCO requirements here: https://github.com/oras-project/oras-py/pull/249/checks?check_run_id=92784221176

Signed-off-by: ahmad <ahmadalgaidy@hotmail.com>
@tomatotomata
tomatotomata force-pushed the codex/push-quiet-output branch from d4bd814 to 1634cdc Compare August 8, 2026 13:48
@tomatotomata

Copy link
Copy Markdown
Contributor Author

The DCO check was the only action-required gate. I amended the head commit with the authorized sign-off Signed-off-by: ahmad <ahmadalgaidy@hotmail.com> and force-pushed the same branch. The code and validation scope are unchanged, so the checks can rerun against the new head.

@vsoch
vsoch merged commit 18c5be8 into oras-project:main Aug 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants