Skip to content

Conversation

@myabc
Copy link
Contributor

@myabc myabc commented Jan 5, 2026

Ticket

https://community.openproject.org/work_packages/70168

What are you trying to accomplish?

Use danger-variant button with leading icon to make the action less ambiguous.

Screenshots

Before

Screenshot 2026-01-05 at 11 37 21

After

Screenshot 2026-01-05 at 11 36 59

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

Use danger-variant button with leading icon to make the action less
ambiguous.

https://community.openproject.org/work_packages/70168
@myabc myabc added bugfix styling ruby Pull requests that update Ruby code needs review labels Jan 5, 2026
@myabc myabc marked this pull request as ready for review January 5, 2026 14:39
Copilot AI review requested due to automatic review settings January 5, 2026 14:39
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Caution

The provided work package version does not match the core version

Details:

Please make sure that:

  • The work package version OR your pull request target branch is correct

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the session revocation button's UI/UX by replacing an icon-only button with a more prominent danger-styled button that includes both an icon and visible text label. This makes the destructive action more clear and reduces ambiguity.

Key Changes

  • Changed from Primer::Beta::IconButton with invisible scheme to Primer::Beta::Button with danger scheme
  • Added visible button text using I18n.t(:button_revoke) instead of just an aria-label
  • Added a leading visual icon (sign-out) to the button

@myabc myabc added this to the 17.0.x milestone Jan 5, 2026
@myabc myabc merged commit 3a9bd2a into release/17.0 Jan 7, 2026
30 checks passed
@myabc myabc deleted the bug/70168-ambiguous-session-revocation-icon branch January 7, 2026 09:32
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix needs review ruby Pull requests that update Ruby code styling

Development

Successfully merging this pull request may close these issues.

3 participants