bug/69230 Use enhanced Primer::OpenProject::AvatarWithFallback to render initials in a styled SVG when avatar img src is nil/blank

[akabiru]

https://community.openproject.org/wp/69230

⚠️ Depends on:

• bug/69230 Extend Primer::Beta::Avatar as Primer::OpenProject::AvatarWithFallback to render initials in a styled SVG when avatar img src is nil/blank primer_view_components#387
• Bump Primer to 0.79.0 #21577

Note

Handling for broken image links (gravatar urls) will followup separately. See: opf/primer_view_components#396

[brunopagno]

Too many open tabs and accidentally pressed the wrong buttons. Did not mean to approve this one yet 😅

Bruno did not mean to approve yet :)

[HDinger]

The changes itself look fine, but I am wondering whether we should not make that cahnge inside the Users::AvatarComponent directly instead of replacing it with Avatar and name (which the existing component is already doing for you).
I am fine however, with keeping it like this for 17.0 given the time we have and do the full replacement later

[akabiru]

AvatarComponent

I’m not certain we can implement that change yet, as it would be an app-wide update, and we would then lose features like hovercards. Regardless, that’s a task I’d prefer to handle separately from the release branch due to the increased blast radius.

[HDinger]

we would then lose features like hovercards.

I think we will be able to preserve them, given that you basically just have to register a stimulus controller if I remember correctly. In any way, I agree, it is too dangerous that shortly before the release 👍

[akabiru]

Sounds good @HDinger I've created a maintenance wp to cater for this change: https://community.openproject.org/wp/70354

[myabc]

Code-wise this looks fine. Unfortunately I still don't have Hocuspocus running successfully in my dev environment, That said - given our exhaustive review of the upstream changes, as well as the fact @HDinger's already looked at this, this should be good to merge! 💯 you're crushing it!