Restructured data.js to data_{lang}.js and data_{lang}_{slug}.js for better memory management #258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
data.js takes up too much space, and hence too much time to load, not a scalable design. restructuring it to data_{lang}.js and data_{lang}_{slug}.js helps in lesser memory loading, as smaller chunks of data are loaded at a time.
Fixes #257
Changes
Major Change:
generate_datafilenow uses two helper functions to generate two separate file:?langquery parameters optional rather than required.locally tested with offliner definition:
See screenshots for reference: