Skip to content

Wrap diagnostic messages in unordered lists and add styling for scrollable lists. #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jan 8, 2026
Merged

Wrap diagnostic messages in unordered lists and add styling for scrollable lists. #2144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions frontend/app/components/diagnostics_view/diagnostics_view.ng.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,21 @@
<div *ngIf="diagnostics.errors.length" class="callout is-critical">
<header>Errors</header>
<li *ngFor="let error of diagnostics.errors" [innerHtml]="error">
</li>
<ul class="callout-list">
<li *ngFor="let error of diagnostics.errors" [innerHtml]="error">
</li>
</ul>
</div>
<div *ngIf="diagnostics.warnings.length" class="callout is-important">
<header>Warnings</header>
<li *ngFor="let warning of diagnostics.warnings" [innerHtml]="warning">
</li>
<ul class="callout-list">
<li *ngFor="let warning of diagnostics.warnings" [innerHtml]="warning">
</li>
</ul>
</div>
<div *ngIf="diagnostics.info.length" class="callout is-helpful">
<header>Info</header>
<li *ngFor="let info of diagnostics.info" [innerHtml]="info">
</li>
<ul class="callout-list">
<li *ngFor="let info of diagnostics.info" [innerHtml]="info">
</li>
</ul>
</div>
16 changes: 16 additions & 0 deletions frontend/app/styles/common.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,22 @@ mat-progress-bar {
padding: 12px 24px;
}

.callout-list {
margin: 10px;
max-height: 20vh;
overflow-y: auto;
list-style-position: outside;
}

.callout-list-item {
display: flex;
align-items: center;
justify-content: space-between;
margin-bottom: 5px;
padding: 5px;
background: rgba(25, 118, 210, 0.20);
}

.callout.is-critical {
border-color: #dd0031;
background: rgba(221, 0, 49, 0.05);
Expand Down
Loading