Add at-least-1-operand verification for collective ops#2917
Open
brucechanglongxu wants to merge 1 commit intoopenxla:mainfrom
Open
Add at-least-1-operand verification for collective ops#2917brucechanglongxu wants to merge 1 commit intoopenxla:mainfrom
brucechanglongxu wants to merge 1 commit intoopenxla:mainfrom
Conversation
AllReduceOp, AllGatherOp, and AllToAllOp all accept variadic operands but didn't verify that at least one is provided. This is enforced in MHLO but was missing in StableHLO. Zero operands would either silently pass verification or crash downstream. Fixes openxla#2764
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hit this while fuzzing — you can construct an all_reduce, all_gather,
or all_to_all with zero variadic operands and it passes verification
silently. MHLO already guards against this but StableHLO doesn't.
The fix adds an early
operands.empty()check in each verifier /type-inference function. Nothing fancy, just parity with MHLO. Also
added a verify test file covering the three ops.
Fixes #2764