Skip to content

Push shardy outliner up past ReshardToCollectives pass. #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

Push shardy outliner up past ReshardToCollectives pass. #1130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions shardy/dialect/sdy/transforms/export/export_pipeline.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,14 @@ void runShardyPartitioner(OpPassManager& pm, int& dumpIndex,
pm.addPass(mlir::sdy::createSaveModuleOpPass(
options.dumpDirectory, "after_explicit_reshards", dumpIndex++));
addCanonicalizerPass(pm, kReshardLabel);
pm.addPass(createExportNamedComputationsPass());
pm.addNestedPass<func::FuncOp>(createReshardToCollectivesPass());
// NOTE: ReshardToCollectives pass above generates all-slice collectives,
// which during the canonicalizer below may be converted to reduce scatters
// by potentially fusing with preceeding all-reduces, which are inserted
// during InsertExplicitReshards pass.
} else {
pm.addPass(createExportNamedComputationsPass());
}
addCanonicalizerPass(pm, kCollectiveLabel);
if (options.enableInsertExplicitCollectives &&
Expand Down Expand Up @@ -98,12 +101,12 @@ void addExportPipeline(OpPassManager& pm, int& dumpIndex,
// reshards/collectives.
if (!options.avoidExportForPartitioning) {
runShardyPartitioner(pm, dumpIndex, options);
} else {
pm.addPass(createExportNamedComputationsPass());
}

if (options.dumpPropagationEdges || options.dumpShardingOrigins) {
pm.addPass(createRemovePropagationDebugInfoPass());
}
pm.addPass(createExportNamedComputationsPass());
if (!options.keepShardingRules) {
pm.addNestedPass<func::FuncOp>(createDropShardingRulesPass());
}
Expand Down
Loading