libmodbus: update to 3.1.11 #28168
Merged
libmodbus: update to 3.1.11 #28168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the2masters
changed the title
Member
|
The commit description could be improved, don't you think? :) Right now, the subject and description are identical. How about adding some release notes instead? Also, which "float endianness issue" are you referring to? Is there a specific issue that should be referenced? A few more questions:
So many questions... :( Relevant release notes: |
fixes float endianness issues in 3.1.8. I use a small, custom application to convert data from my electricity meter into Modbus format for my inverter and wallbox. I developed this program against an earlier version of libmodbus on x86, and it ran flawlessly on my ath79 router (big endian). After migrating to a Mediatek router (little endian), the program only outputted huge, meaningless values. However, it ran perfectly fine on my x86 system (little endian), which is running Fedora with libmodbus v3.1.11. I then found several bug reports and the changelogs for libmodbus 3.1.11 that described and resolved my problem. So update openwrt to 3.1.11. Signed-off-by: Stefan Hellermann <[email protected]>
the2masters
force-pushed
the
libmodbus
branch
from
6eb2fb5 to
234dabf
Compare
Contributor
Author
|
@BKPepe: I hope I was able to answer all your questions :-) |
Member
|
I'm fine with it, so let's merge it. I also compile-tested for mxs platform, and also run-tested it on Raspi. (However, both are little-endian systems, so I cannot tell much about the endianess stuff). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes float endianness issues in 3.1.8.
I use a small, custom application to convert data from my electricity meter into Modbus format for my inverter and wallbox. I developed against an earlier version of libmodbus on x86, and it ran flawlessly on my ath79 router (big endian). After migrating to a Mediatek router (little endian), the program only outputted huge, meaningless values. However, it ran perfectly fine on my x86 system (little endian), which is running Fedora with libmodbus v3.1.11.
I then found upstream bug reports stephane/libmodbus#665 stephane/libmodbus#757 and the changelog of libmodbus v3.1.11 with the fix. Update openwrt to libmodbus v3.1.11 to get the fix.
📦 Package Details
Maintainer: @mhei
🧪 Run Testing Details
✅ Formalities