Open
Conversation
There are a number of broken device specifications that redundantly map various images to the same device names. Handle most of these by ensuring that the actual device name maps to itself, rather than some arbitrary value in 'SUPPORTED_DEVICES' due to these incorrect device mappings in the profiles.json. Fixes: openwrt/openwrt#22541 Signed-off-by: Eric Fahlgren <ericfahlgren@gmail.com>
1 task
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1593 +/- ##
===========================================
+ Coverage 80.75% 91.57% +10.81%
===========================================
Files 15 16 +1
Lines 977 1745 +768
===========================================
+ Hits 789 1598 +809
+ Misses 188 147 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a number of broken device specifications that redundantly map various images to the same device names. Handle most of these by ensuring that the actual device name maps to itself, rather than some arbitrary value in 'SUPPORTED_DEVICES' due to these incorrect device mappings in the profiles.json.
Fixes: openwrt/openwrt#22541