Skip to content

fix: prevent calc(% - px) collapse in flex items and input focus scroll jump#851

Merged
andycall merged 2 commits intomainfrom
fix/scrollable_size
Feb 8, 2026
Merged

fix: prevent calc(% - px) collapse in flex items and input focus scroll jump#851
andycall merged 2 commits intomainfrom
fix/scrollable_size

Conversation

@andycall
Copy link
Member

@andycall andycall commented Feb 8, 2026

Summary

  • fix(webf): Prevent calc(% - px) from collapsing to 0 inside shrink-to-fit flex items by refining _hasDefiniteInlineSize to not treat auto-sized flex item widths as definite for percentage resolution
  • fix(rendering): Prevent input focus from scrolling the outer page to top by forwarding revealed descendant bounds (instead of null) to ancestor showOnScreen calls

Test plan

  • Added widget unit test for calc layout in shrink-to-fit flex items (css_calc_layout_test.dart)
  • Added widget unit test for show-on-screen focus behavior (show_on_screen_focus_test.dart)
  • Added integration test with snapshot for flex-shrink-to-fit-calc pattern
  • Updated existing flex-grow snapshots

@vercel
Copy link

vercel bot commented Feb 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
use-case Ready Ready Preview, Comment Feb 8, 2026 5:02pm
vue_usecase Ready Ready Preview, Comment Feb 8, 2026 5:02pm

Request Review

@andycall andycall merged commit ccf3170 into main Feb 8, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant