Skip to content

feat: add vcld feature - #50

Open
lukasjhan wants to merge 5 commits into
openwallet-foundation-labs:mainfrom
lukasjhan:feat/vcld
Open

feat: add vcld feature#50
lukasjhan wants to merge 5 commits into
openwallet-foundation-labs:mainfrom
lukasjhan:feat/vcld

Conversation

@lukasjhan

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
@lukasjhan lukasjhan self-assigned this Jun 14, 2025
@lukasjhan lukasjhan linked an issue Jun 19, 2025 that may be closed by this pull request

@Dtitkaio Dtitkaio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. I left some comments!


// Sample data (will be expanded)
const sampleDoc: JsonLdDocument = {
'@context': 'https://www.w3.org/2018/credentials/v1',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking, the context has to include all the metadata in the ld part, in our case, including degree and its elements, i.e., type and name. maybe, we can use an example defined in jsonld playground.
https://json-ld.org/playground/

maybe Person??

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, we would like to add json-ld processing when it is needed. The problem is it is not specified in the standard. If I had to guess, we may want to add the semantic processing at least for a verifier after verifying the credential for business logic.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe, we can return the decoded credential with ld part processed after verification??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate JSON LD parser for SD JWT VCLD

2 participants