Skip to content

TEST: disable preconnect_ctx_global test#1277

Open
ikryukov wants to merge 1 commit intoopenucx:masterfrom
ikryukov:disable-hanging-tests
Open

TEST: disable preconnect_ctx_global test#1277
ikryukov wants to merge 1 commit intoopenucx:masterfrom
ikryukov:disable-hanging-tests

Conversation

@ikryukov
Copy link
Copy Markdown
Collaborator

@ikryukov ikryukov commented Mar 9, 2026

What

Disable preconnect_ctx_global gtest tests.

Why ?

These tests use UCC_JOB_CTX_LOCAL mode where all processes are threads in the same OS process. During teardown, ~UccJob destroys contexts in parallel threads, each calling ucc_tl_ucp_close_eps with FLUSH mode. On shared memory transport (no IB), FLUSH has no timeout mechanism — it spins forever waiting for remote workers that are no longer being progressed. This causes CI to hang until the global timeout kills the job.

How ?

Added the gtest DISABLED_ prefix to both test names. The tests are still compiled but skipped at runtime.

related to #1273

@ikryukov
Copy link
Copy Markdown
Collaborator Author

ikryukov commented Mar 9, 2026

/build

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 9, 2026

Greptile Summary

This PR disables the team_create_multiple_preconnect_ctx_global gtest by prepending the standard GTest DISABLED_ prefix, preventing CI from hanging when the test spins forever during teardown on shared-memory transports. The change is minimal, correct, and consistent with the already-disabled DISABLED_team_create_multiple_preconnect_ctx_local test.

Minor note: The PR description states "These tests use UCC_JOB_CTX_LOCAL mode" as the root cause, but the newly disabled test (line 82) constructs its UccJob with UCC_JOB_CTX_GLOBAL. The underlying hang mechanism likely applies to both modes in the gtest thread-based environment, but the description could be slightly misleading for future readers trying to understand when it is safe to re-enable these tests.

Confidence Score: 5/5

  • This PR is safe to merge — it only adds a GTest DISABLED_ prefix to one test name with no risk of regression.
  • The change is a single token added to a test name, which is a well-understood GTest mechanism. It fixes a CI hang with no production code touched and no logic altered.
  • No files require special attention.

Important Files Changed

Filename Overview
test/gtest/core/test_team.cc Single-line change adding the GTest DISABLED_ prefix to team_create_multiple_preconnect_ctx_global, preventing it from running automatically while keeping it compiled. Change is minimal and correct.

Last reviewed commit: 53fee1c

Signed-off-by: Ilya Kryukov <ikryukov@nvidia.com>
@ikryukov ikryukov force-pushed the disable-hanging-tests branch from dda65d4 to 53fee1c Compare March 10, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants