Replace bashisms with POSIX syntax#1006
Open
jeroen-mostert wants to merge 1 commit intoopenucx:masterfrom
Open
Replace bashisms with POSIX syntax#1006jeroen-mostert wants to merge 1 commit intoopenucx:masterfrom
jeroen-mostert wants to merge 1 commit intoopenucx:masterfrom
Conversation
|
Can one of the admins verify this patch? |
Contributor
|
@jeroen-mostert What is your affiliation? Thanks. |
Author
|
This patch is a product of my spare time, neither commissioned by, nor approved of, nor sponsored by, nor produced during working hours, nor aligned with the purposes of the company I also happen to be employed for. I will not sign any document, waiver, contract or agreement to release any rights associated with it, but release this code into the public domain as per the CC0 universal deed, including but not limited to giving others permission to use the same code for merging purposes without attribution. I hope that answers your question. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces some bashisms (notably equality check with
==and substring replacement) with POSIX equivalents, for distros whereshoperates in strict POSIX mode. I will not claim that all bashisms are thereby purged from the configure files (they may lurk in conditionals not taken), but at least it allows a basic build to proceed.