Skip to content

fix staking in e2e#2508

Draft
open-junius wants to merge 3 commits intodevnet-readyfrom
fix-staking-e2e
Draft

fix staking in e2e#2508
open-junius wants to merge 3 commits intodevnet-readyfrom
fix-staking-e2e

Conversation

@open-junius
Copy link
Contributor

Description

staking e2e test failed after the emission update.

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

Copy link
Collaborator

@evgeny-s evgeny-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't update the assertion logic, but instead we need to get the value from alphaV2. Check this PR for more details.

assert.ok(stakeFromContract > stakeBefore)
const stakeAfter = await api.query.SubtensorModule.Alpha.getValue(convertPublicKeyToSs58(hotkey.publicKey), convertH160ToSS58(wallet.address), netuid)
assert.ok(stakeAfter > stakeBefore)
assert.ok(stakeAfter >= stakeBefore)
Copy link
Collaborator

@evgeny-s evgeny-s Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't update the assertion logic, but instead we need to get the value from alphaV2. Check this PR for more details.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! will update it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants