Skip to content

Deprecate drug, pharmacogenomics, targetEngine, and knownDrug steps#405

Merged
DSuveges merged 2 commits intomainfrom
4247_drug_adjustments
Feb 27, 2026
Merged

Deprecate drug, pharmacogenomics, targetEngine, and knownDrug steps#405
DSuveges merged 2 commits intomainfrom
4247_drug_adjustments

Conversation

@d0choa
Copy link
Contributor

@d0choa d0choa commented Jan 16, 2026

Related to opentargets/issues#4247

  • Remove drug, pharmacogenomics, targetEngine, and knownDrug step registrations from Main.scala
  • Remove drug, pharmacogenomics, targetEngine, and knownDrug configurations from Configuration.scala Steps case class
  • Remove unused configuration case classes (DrugSection, InputExtension, PharmacogenomicsSection, TargetEngineSection, KnownDrugSection)
  • Update reference.conf: remove deprecated step configurations and update drug references to direct paths
    • search, openfda, literature steps now reference external drug datasets
    • drug references updated to use paths: drug_molecule, drug_indication, drug_mechanism_of_action
  • Remove target-based computation from openFDA step (keep only chembl_id dimension)
  • Remove fda_targets_unfiltered, fda_targets_results, and sampling_targets outputs from openfda
  • Delete all drug, pharmacogenomics, targetEngine, and knownDrug implementation files
  • Delete DrugUtils utility (no longer used)
  • Delete related test files for deprecated modules
  • Modifies ETL search to use new indications as input

Configuration test passes - validates configuration structure integrity

@DSuveges DSuveges marked this pull request as ready for review February 27, 2026 11:15
d0choa and others added 2 commits February 27, 2026 11:49
- Remove drug, pharmacogenomics, targetEngine, and knownDrug step registrations from Main.scala
- Remove drug, pharmacogenomics, targetEngine, and knownDrug configurations from Configuration.scala Steps case class
- Remove unused configuration case classes (DrugSection, InputExtension, PharmacogenomicsSection, TargetEngineSection, KnownDrugSection)
- Update reference.conf: remove deprecated step configurations and update drug references to direct paths
  - search, openfda, literature steps now reference external drug datasets
  - drug references updated to use paths: drug_molecule, drug_indication, drug_mechanism_of_action
- Remove target-based computation from openFDA step (keep only chembl_id dimension)
- Remove fda_targets_unfiltered, fda_targets_results, and sampling_targets outputs from openfda
- Delete all drug, pharmacogenomics, targetEngine, and knownDrug implementation files
- Delete DrugUtils utility (no longer used)
- Delete related test files for deprecated modules

Configuration test passes - validates configuration structure integrity
@DSuveges DSuveges force-pushed the 4247_drug_adjustments branch from 1fc0bde to 94970db Compare February 27, 2026 11:53
@DSuveges DSuveges self-requested a review February 27, 2026 11:57
Copy link
Contributor

@DSuveges DSuveges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe all OK.

@DSuveges DSuveges merged commit caf1ed9 into main Feb 27, 2026
2 checks passed
@DSuveges DSuveges deleted the 4247_drug_adjustments branch February 27, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants