Skip to content

Bump @rapideditor/location-conflation from 2.0.1 to 3.0.0 in the rapideditor group across 1 directory#12259

Open
dependabot[bot] wants to merge 2 commits intodevelopfrom
dependabot/npm_and_yarn/rapideditor-ba1c8518f0
Open

Bump @rapideditor/location-conflation from 2.0.1 to 3.0.0 in the rapideditor group across 1 directory#12259
dependabot[bot] wants to merge 2 commits intodevelopfrom
dependabot/npm_and_yarn/rapideditor-ba1c8518f0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Apr 27, 2026

Bumps the rapideditor group with 1 update in the / directory: @rapideditor/location-conflation.

Updates @rapideditor/location-conflation from 2.0.1 to 3.0.0

Release notes

Sourced from @​rapideditor/location-conflation's releases.

v3.0.0

https://github.com/rapideditor/location-conflation/blob/main/CHANGELOG.md#300

Changelog

Sourced from @​rapideditor/location-conflation's changelog.

3.0.0

2026-Apr-24
  • Improve TypeScript compatibility with other projects by extending the standard DefinitelyTyped GeoJSON types. Improve TypeScript strictness, modernize. (#75)
  • NEW: LocationConflation now handles spatial indexing and point-in-polygon lookups.
    • Indexing was previously the responsibility of downstream projects (Name-Suggestion-Index, Rapid, iD). This change allows those projects to remove a bunch of complex code.
    • registerLocationSets(objects) - Accepts an array of locationSet-bearing objects and builds an include/exclude inverted index and which-polygon spatial index. Tolerant of bad input:
      • Objects with missing/empty/invalid locationSet fall back to world (+[Q2]).
      • Individual invalid include/exclude components are silently ignored.
    • locationSetsAt([lon, lat]) — returns a Map<locationSetID, area> of locationSets covering the given point.
      • Returned Map gives O(1) membership tests for the common "is this locationSet valid here?" check.
      • World locationSet (+[Q2]) is pre-registered, so any valid WGS84 coordinate will include world in results — no need to manually register a world locationSet first.
    • getLocationSetArea(locationSetID) — returns the approximate km² of a registered locationSet.
  • ⚠️ Removed "non-strict" mode. Previous "strict" mode behavior is now the default.
    • validateLocation, validateLocationSet, resolveLocation, and resolveLocationSet now always throw on invalid input.
    • Callers that were relying on "non-strict" null returns should wrap calls in try/catch.
    • The .strict property has been removed.
    • validateLocationSet no longer mutates its input (previously, "non-strict" mode would set locationSet.include = ['Q2'] on empty input).
  • ⚠️ Deprecate direct access to internal resolved GeoJSON _cache
    • A _cache accessor is provided for backward compatibility, but will be removed in a future release. Downstream projects that previously accessed the internal _cache should stop doing that.
    • Add addFeatures(), removeFeatures(), clearFeatures() for managing custom .geojson cache after construction. (The constructor still optionally accepts custom features, but delegates to addFeatures).
    • Add rebuildIndex() — This is automatically invoked by addFeatures, removeFeatures, clearFeatures, registerLocationSets. (But if you are still changing the _cache, you'll need to call this after making changes).

#75: rapideditor/location-conflation#75

Commits
  • 7aa988e v3.0.0
  • 37d9be5 Update dependencies, eslint config can be a .ts file
  • 8f6cf39 More docs cleanup, more tests to ensure world location 'Q2' behavior
  • 844b591 v3: refactor locationSetsAt, add world pre-seeding, add API.md
  • b6256ee Convert tests to TypeScript and modernize test suite
  • c0a8307 Remove strict property (3.0.0 breaking change)
  • dd5ed17 TypeScript strictness, code quality, and tooling improvements
  • cf5219c Update dependencies, update project docs, guides, prompts
  • 62c03df NSI and OCI are not scoped packages, so 'osmlab' should not be here.
  • 374a65f Publish not working. npm pkg fix suggests this. idk why
  • See full diff in compare view

@dependabot dependabot Bot added the chore-dependabot Automated PRs for keeping dependencies up-to-date label Apr 27, 2026
@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Apr 27, 2026

According to the changelog we should

  • Before/after merge check our types. I don't expect anything to be done given that we dont have a lot of types to begin with.

  • More interestingly create a follow up chore to refactor our code to rely on the package for the lookup; see changelog.

https://github.com/rapideditor/location-conflation/blob/main/CHANGELOG.md

@matkoniecz
Copy link
Copy Markdown
Contributor

matkoniecz commented Apr 29, 2026

from CI

Error: modules/core/LocationManager.ts(1,53): error TS2614: Module '"@rapideditor/location-conflation"' has no exported member 'GeoJSONFeature'. Did you mean to use 'import GeoJSONFeature from "@rapideditor/location-conflation"' instead?
Error: modules/core/LocationManager.ts(1,74): error TS2614: Module '"@rapideditor/location-conflation"' has no exported member 'FeatureProperties'. Did you mean to use 'import FeatureProperties from "@rapideditor/location-conflation"' instead?
Error: modules/core/LocationManager.ts(1,98): error TS2724: '"@rapideditor/location-conflation"' has no exported member named 'FeatureCollection'. Did you mean 'LocoFeatureCollection'?
Error: modules/core/LocationManager.ts(197,25): error TS7006: Parameter 'feature' implicitly has an 'any' type.
ERROR: "test:typecheck" exited with 2.
Error: Process completed with exit code 1.

Bumps the rapideditor group with 1 update in the / directory: [@rapideditor/location-conflation](https://github.com/rapideditor/location-conflation).


Updates `@rapideditor/location-conflation` from 2.0.1 to 3.0.0
- [Release notes](https://github.com/rapideditor/location-conflation/releases)
- [Changelog](https://github.com/rapideditor/location-conflation/blob/main/CHANGELOG.md)
- [Commits](rapideditor/location-conflation@v2.0.1...v3.0.0)

---
updated-dependencies:
- dependency-name: "@rapideditor/location-conflation"
  dependency-version: 3.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: rapideditor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot Bot changed the title Bump @rapideditor/location-conflation from 2.0.1 to 3.0.0 in the rapideditor group Bump @rapideditor/location-conflation from 2.0.1 to 3.0.0 in the rapideditor group across 1 directory Apr 30, 2026
@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/rapideditor-ba1c8518f0 branch from 7557366 to 0933749 Compare April 30, 2026 06:43
@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Apr 30, 2026

FYI: I am looking into preparing a PR for those two things (separate).

@tyrasd
Copy link
Copy Markdown
Member

tyrasd commented Apr 30, 2026

It's great that all this indexing is now handled by the library itself.

FYI: I am looking into preparing a PR for those two things (separate).

@tordans: sorry, I did not see your message in time. I've already upgraded the logic to use the upstream methods accordingly. Can you please give this a look at commit
1a2399b whether this matches what you also did / had in mind?

I'm going to keep this open for a bit (merging after the upcoming release), so we can test it thoroughly for potential regressions.

@tyrasd tyrasd force-pushed the dependabot/npm_and_yarn/rapideditor-ba1c8518f0 branch from d4ece43 to 1a2399b Compare April 30, 2026 08:59
@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Apr 30, 2026

Can you please give this a look at commit 1a2399b whether this matches what you also did / had in mind?

I had Cursor compare our approaches and yours is doing the better cleanup so no new input from my side :-). +1 for testing during the next beta-cycle but but I don't see anything special to look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore-dependabot Automated PRs for keeping dependencies up-to-date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants