Fix shortcuts modal scrolling: constrain scroll to content area and preserve header scroll behavior#12254
Open
isabelladesi wants to merge 1 commit intoopenstreetmap:developfrom
Open
Conversation
… header fixed, and forward scroll events from header
|
How would you say this differs from #10612 and what makes this approach better? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10591
This change fixes the scrollbar behavior in the Keyboard Shortcuts modal. Previously, the scrollbar extended into the header area because scrolling was applied to the entire modal content container. This caused the header to appear visually inconsistent and not remain fixed during scrolling.
This fix:
Additionally, this change preserves expected scrolling behavior by forwarding wheel events from the header to the scrollable content area. This ensures users can still scroll the modal even when hovering over the header.
Testing
No regressions observed in the test suite (
npm testpassed).