Skip to content

Add member controls UI for relations (load and select actions)#12158

Open
Shyam-123pandey wants to merge 2 commits intoopenstreetmap:developfrom
Shyam-123pandey:feature/select-all-members-of-a-Relation
Open

Add member controls UI for relations (load and select actions)#12158
Shyam-123pandey wants to merge 2 commits intoopenstreetmap:developfrom
Shyam-123pandey:feature/select-all-members-of-a-Relation

Conversation

@Shyam-123pandey
Copy link
Copy Markdown
Contributor

@Shyam-123pandey Shyam-123pandey commented Apr 1, 2026

Vedio of testing:

fixed122.mp4

Add a compact set of controls above the relation members list to support bulk operations.

This introduces actions to:

  • load all relation members
  • select currently loaded members
  • select all members when fully loaded

The "select all" action is disabled when not all members are loaded to avoid partial edits and unexpected behavior.

This change focuses on making bulk operations explicit and safe, instead of relying on implicit keyboard shortcuts.
closes: #12122

Copilot AI review requested due to automatic review settings April 1, 2026 16:26
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a compact “member controls” button group intended to make bulk operations on relation members explicit (load/select), addressing #12122.

Changes:

  • Added a new controls row (load/select actions) above the membership list UI.
  • Introduced styling for the new controls in a dedicated CSS file.
  • Minor formatting/style tweak in modeSelect keybinding chaining.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.

File Description
modules/ui/sections/raw_membership_editor.js Adds functions and UI controls to load/select relation members from the membership editor panel.
modules/modes/select.js Small keybinding chain formatting change.
css/raw_membership_editor.css Adds styles for the new member controls button group.

Comment thread modules/ui/sections/raw_membership_editor.js Outdated
Comment thread modules/ui/sections/raw_membership_editor.js
Comment thread modules/ui/sections/raw_membership_editor.js Outdated
Comment thread modules/ui/sections/raw_membership_editor.js Outdated
Comment thread modules/ui/sections/raw_membership_editor.js
Comment thread modules/ui/sections/raw_membership_editor.js
Comment thread modules/ui/sections/raw_membership_editor.js
Comment thread modules/modes/select.js Outdated
@Shyam-123pandey
Copy link
Copy Markdown
Contributor Author

All suggestion will fix tomorrow, will do updated commit. thanks

@Shyam-123pandey
Copy link
Copy Markdown
Contributor Author

Shyam-123pandey commented Apr 3, 2026

test

Now all test have been passed, will do next commit shortly.
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Ctrl+Down to select all members of a Relation

2 participants