Add member controls UI for relations (load and select actions)#12158
Open
Shyam-123pandey wants to merge 2 commits intoopenstreetmap:developfrom
Open
Add member controls UI for relations (load and select actions)#12158Shyam-123pandey wants to merge 2 commits intoopenstreetmap:developfrom
Shyam-123pandey wants to merge 2 commits intoopenstreetmap:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a compact “member controls” button group intended to make bulk operations on relation members explicit (load/select), addressing #12122.
Changes:
- Added a new controls row (load/select actions) above the membership list UI.
- Introduced styling for the new controls in a dedicated CSS file.
- Minor formatting/style tweak in
modeSelectkeybinding chaining.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| modules/ui/sections/raw_membership_editor.js | Adds functions and UI controls to load/select relation members from the membership editor panel. |
| modules/modes/select.js | Small keybinding chain formatting change. |
| css/raw_membership_editor.css | Adds styles for the new member controls button group. |
Contributor
Author
|
All suggestion will fix tomorrow, will do updated commit. thanks |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Vedio of testing:
fixed122.mp4
Add a compact set of controls above the relation members list to support bulk operations.
This introduces actions to:
The "select all" action is disabled when not all members are loaded to avoid partial edits and unexpected behavior.
This change focuses on making bulk operations explicit and safe, instead of relying on implicit keyboard shortcuts.
closes: #12122