Fix: deselect way when selecting first/last node#12135
Open
kamalzada37 wants to merge 1 commit intoopenstreetmap:developfrom
Open
Fix: deselect way when selecting first/last node#12135kamalzada37 wants to merge 1 commit intoopenstreetmap:developfrom
kamalzada37 wants to merge 1 commit intoopenstreetmap:developfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
Contributor
|
@kamalzada37 Do you plan to finish it? |
Author
|
Yes sir I will do I just forgot.
Recently I deployed my bachelors project so I was busy with that.
Right now I will work on this task
…On Wed, 15 Apr 2026 at 19:38 Mateusz Konieczny ***@***.***> wrote:
*matkoniecz* left a comment (openstreetmap/iD#12135)
<#12135 (comment)>
@kamalzada37 <https://github.com/kamalzada37> Do you plan to finish it?
—
Reply to this email directly, view it on GitHub
<#12135 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BLUUETFFW3GJVX4HLG3PMD34V6NHHAVCNFSM6AAAAACXE7MU5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DENJSHE4DKOJSGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
|
@kamalzada37 do you plan to finish it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #10962
When selecting the first or last node of a way using keyboard shortcuts, the way remained visually selected, which caused confusion.
This change ensures that only the selected node remains active, and the parent way is properly deselected.
The fix replaces reuse of the existing mode with a fresh select mode, preventing stale selection state.
Tested locally: