Side indicators on the map for directionalCombos#12099
Draft
tordans wants to merge 3 commits intoopenstreetmap:developfrom
Draft
Side indicators on the map for directionalCombos#12099tordans wants to merge 3 commits intoopenstreetmap:developfrom
directionalCombos#12099tordans wants to merge 3 commits intoopenstreetmap:developfrom
Conversation
directionalCombos
Contributor
|
Thanks for looking into it! My thoughts: in the first and second option these markings seems a bit detached from way itself. Not entirely sure how intuitive it will be. In the third option these overlaps between segments are a bit annoying, but overall I really, really like on-the-map view. |
Collaborator
Author
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

A take to resolve #11950
Note
This is a draft PR meant to discuss styling and interaction.
The code is generated and checked only a litte; not reviewed yet and not meant to be reviewed.
Right now, it is quite hard to add and review direction input fields on the map. One has to find the small
arrow – that is sometimes hidden below the label name – and then extrapolate the left|right side based on that.
The idea of this change is, to give a visual indicator on the map when using the specific side.
There are a few cases out there that use a similar style…
Example Screenshot from Speedwalk
But this solution suggests to only show the side that we are selecting ATM and only when we are working on this specific field/row.
Blue arrows
The idea is to reuse the color we use for the newly added helper lines from #11774
Red arrow
The idea here is to re-use the red color that we use for the "high is highlighted" and just add a "we look at this direction for this field" icon.
Red select indicator (and label)
The idea here is to reuse the selection indicator below the line and move it to be bigger on the side that we indicate. (Ideally this would still show on the "other" side and just make the indicator side larger; here it moves.)
This also shows how we might show the key+value as an additional label. (This is not fleshed out, yet…)
Other options?
#10303 does something with side, but there is no style we can reuse here, IMO. Other than using the gray color, maybe. But I don't think this will help here. We use the gray indicators for things that are visible on the map all the time; the blue and red is for things that happen on indicator.
The Code will handle
forward|backwardas well by translating it torigth|left. Does this sound right and what field could we test this on? https://github.com/openstreetmap/iD/pull/12099/changes#diff-4fa4b7fd7b8bbe73f21424cef0b08d14b77f072153d2f744c5728e47f1585569R33-R36