fix plausible regression from d491a71a938135f9, made avty disable global#1985
Open
avg-I wants to merge 1 commit intoopenshwprojects:mainfrom
Open
fix plausible regression from d491a71a938135f9, made avty disable global#1985avg-I wants to merge 1 commit intoopenshwprojects:mainfrom
avg-I wants to merge 1 commit intoopenshwprojects:mainfrom
Conversation
It's easier to reason about the change if we consider when the availability topic is not added. Originally that was when isSensor && flagavty, that is, when an entity was considered to be a sensor and flag 35 was set. After commit d491a71, it became isSensor || flagavty. That is, (A) if flag 35 is set then all entities are stripped of the availability topic and (B) even when the flag is not set, then any entity considered to be a sensor would also be stripped of the topic. I am confident that (A) was the intent and (B) is a bug. So, we should simply check only flagavty.
Author
|
The issue was also described and discussed here https://www.elektroda.com/rtvforum/topic4162760.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's easier to reason about the change if we consider when the availability topic is not added.
Originally that was when
isSensor && flagavty, that is, when an entity was considered to be a sensor and flag 35 was set.After commit d491a71, it became
isSensor || flagavty. That is, (A) if flag 35 is set then all entities are stripped of the availability topic and (B) even when the flag is not set, then any entity considered to be a sensor would also be stripped of the topic.I am confident that (A) was the intent and (B) is a bug.
So, we should simply check only
flagavty.