Skip to content

[release-4.21] OCPBUGS-88564: fix CUDN status condition tests for new TransportAccepted condition#31300

Open
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.21from
openshift-cherrypick-robot:cherry-pick-30958-to-release-4.21
Open

[release-4.21] OCPBUGS-88564: fix CUDN status condition tests for new TransportAccepted condition#31300
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.21from
openshift-cherrypick-robot:cherry-pick-30958-to-release-4.21

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #30958

/assign arkadeepsen

upstream ovn-kubernetes commit [0] added a new TransportAccepted
status condition to ClusterUserDefinedNetwork resources. two tests
and a helper function assumed the condition list only contained
network conditions and broke when TransportAccepted appeared.

these tests are duplicates of the upstream ovn-kubernetes e2e tests
which have already been fixed in the same commit. the upstream
tests will run in openshift CI via the OTE binary once that
framework is in production. these tests can be removed at that
point, but until then this keeps them working.

fixes:
- validateClusterUDNStatusReportsActiveNamespacesFunc: iterate
  conditions to find NetworkCreated/NetworkReady instead of
  assuming conditions
- "should report not-ready" test: use ContainElement instead of
  ConsistOf so extra conditions don't cause failures

[0] ovn-kubernetes/ovn-kubernetes@b855462

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jun 15, 2026
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8a7d9f9e-39bc-405b-be65-ce5d0dad384e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@arkadeepsen

Copy link
Copy Markdown
Member

/payload-job-with-prs periodic-ci-openshift-release-main-ci-4.21-e2e-aws-ovn openshift/ovn-kubernetes#3243

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@arkadeepsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-4.21-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5ddfe460-6881-11f1-8f18-58a0ded1aabf-0

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign kyrtapz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@arkadeepsen

Copy link
Copy Markdown
Member

Hey @kyrtapz, for the 4.21 branch sync PR (openshift/ovn-ubernetes#3243) we need this one to go in first.
Check #31300 (comment)

@arkadeepsen

Copy link
Copy Markdown
Member

/jira cherrypick OCPBUGS-88563

@openshift-ci-robot

Copy link
Copy Markdown

@arkadeepsen: Jira Issue OCPBUGS-88563 has been cloned as Jira Issue OCPBUGS-88564. Will retitle bug to link to clone.
/retitle OCPBUGS-88564: [release-4.21] NO-JIRA: fix CUDN status condition tests for new TransportAccepted condition

Details

In response to this:

/jira cherrypick OCPBUGS-88563

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.21] NO-JIRA: fix CUDN status condition tests for new TransportAccepted condition OCPBUGS-88564: [release-4.21] NO-JIRA: fix CUDN status condition tests for new TransportAccepted condition Jun 15, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 15, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-88564, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-88563 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-88563 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (core-networking-bot@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #30958

/assign arkadeepsen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@arkadeepsen

Copy link
Copy Markdown
Member

/retitle [release-4.21] OCPBUGS-88564: fix CUDN status condition tests for new TransportAccepted condition

@openshift-ci openshift-ci Bot changed the title OCPBUGS-88564: [release-4.21] NO-JIRA: fix CUDN status condition tests for new TransportAccepted condition [release-4.21] OCPBUGS-88564: fix CUDN status condition tests for new TransportAccepted condition Jun 15, 2026
@arkadeepsen

Copy link
Copy Markdown
Member

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@arkadeepsen: This pull request references Jira Issue OCPBUGS-88564, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-88563 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-88563 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (core-networking-bot@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@arkadeepsen

Copy link
Copy Markdown
Member

/assign @kyrtapz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants