[release-4.21] OCPBUGS-88564: fix CUDN status condition tests for new TransportAccepted condition#31300
Conversation
upstream ovn-kubernetes commit [0] added a new TransportAccepted status condition to ClusterUserDefinedNetwork resources. two tests and a helper function assumed the condition list only contained network conditions and broke when TransportAccepted appeared. these tests are duplicates of the upstream ovn-kubernetes e2e tests which have already been fixed in the same commit. the upstream tests will run in openshift CI via the OTE binary once that framework is in production. these tests can be removed at that point, but until then this keeps them working. fixes: - validateClusterUDNStatusReportsActiveNamespacesFunc: iterate conditions to find NetworkCreated/NetworkReady instead of assuming conditions - "should report not-ready" test: use ContainElement instead of ConsistOf so extra conditions don't cause failures [0] ovn-kubernetes/ovn-kubernetes@b855462 Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/payload-job-with-prs periodic-ci-openshift-release-main-ci-4.21-e2e-aws-ovn openshift/ovn-kubernetes#3243 |
|
@arkadeepsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5ddfe460-6881-11f1-8f18-58a0ded1aabf-0 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hey @kyrtapz, for the 4.21 branch sync PR (openshift/ovn-ubernetes#3243) we need this one to go in first. |
|
/jira cherrypick OCPBUGS-88563 |
|
@arkadeepsen: Jira Issue OCPBUGS-88563 has been cloned as Jira Issue OCPBUGS-88564. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-88564, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (core-networking-bot@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retitle [release-4.21] OCPBUGS-88564: fix CUDN status condition tests for new TransportAccepted condition |
|
/jira refresh |
|
@arkadeepsen: This pull request references Jira Issue OCPBUGS-88564, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (core-networking-bot@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @kyrtapz |
This is an automated cherry-pick of #30958
/assign arkadeepsen