SRVKP-11003: React 18 readiness#999
SRVKP-11003: React 18 readiness#999arvindk-softwaredev merged 1 commit intoopenshift-pipelines:masterfrom
Conversation
anwesha-palit-redhat
requested review from
arvindk-softwaredev
and removed request for
pratap0007 and
vdemeester
anwesha-palit-redhat
force-pushed
the
feat/SRVKP-11003
branch
3 times, most recently
from
1531d23 to
cf5e411
Compare
|
/retest |
anwesha-palit-redhat
force-pushed
the
feat/SRVKP-11003
branch
from
cf5e411 to
3225b5b
Compare
anwesha-palit-redhat
changed the title
|
@anwesha-palit-redhat: This pull request references SRVKP-11003 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
anwesha-palit-redhat
force-pushed
the
feat/SRVKP-11003
branch
from
3225b5b to
a8a56b5
Compare
|
/retest |
|
/test images |
|
/retest |
package.json
Outdated
| "webpack-cli": "^5.1.4", | ||
| "ts-node": "^10.9.2", | ||
| "typescript": "5.9.3", | ||
| "webpack": "5.100.0", |
There was a problem hiding this comment.
we need to add ^ for the webpack to be taking similar version as console
| "react-rnd": "^10.3.4", | ||
| "react-router-dom-v5-compat": "^6.30.0", | ||
| "react-router-dom": "5.3.x", |
There was a problem hiding this comment.
we need to update react-router to 7 for console compatibility
There was a problem hiding this comment.
yes we will be taking this up in a separate Jira
| @@ -1,4 +1,5 @@ | |||
| import * as React from 'react'; | |||
| import type { FC, Ref } from 'react'; | |||
| import { useState, useEffect } from 'react'; | |||
There was a problem hiding this comment.
nit: why are we have two separate imports from 'react'
There was a problem hiding this comment.
This is only needed for type checking—and not included in the compiled JS
- Treats FC like a runtime import (even though it isn’t used at runtime)
- May add unnecessary code (or at least unnecessary import statements) in the compiled output
- Is less optimal for bundling/tree-shaking
anwesha-palit-redhat
force-pushed
the
feat/SRVKP-11003
branch
3 times, most recently
from
0f334b1 to
12592b1
Compare
anwesha-palit-redhat
force-pushed
the
feat/SRVKP-11003
branch
from
12592b1 to
f9bcbd9
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anwesha-palit-redhat, arvindk-softwaredev The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@anwesha-palit-redhat: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
arvindk-softwaredev
merged commit 14a239b
into
openshift-pipelines:master
3 participants
No description provided.