SRVKP-11123: Upgrade dependencies and resolve TypeScript, i18n and CI job issues#1001
Conversation
|
@anwesha-palit-redhat: This pull request references SRVKP-11123 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
9185836 to
ba69488
Compare
|
@anwesha-palit-redhat: This pull request references SRVKP-11123 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
f720a87 to
c4e2d4c
Compare
c4e2d4c to
660064f
Compare
|
@anwesha-palit-redhat: This pull request references SRVKP-11123 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| // but doesn't skip hot-update assets, causing false-positive errors during HMR. | ||
| // afterEmit runs after the error is pushed (processAssets) but before done reports it. | ||
| { | ||
| /* { |
There was a problem hiding this comment.
nit: will this affect HMR in local?
There was a problem hiding this comment.
Yes it will. It will fail with the same error we faced earlier, therefore I left the code and commented it, so that during dev we can uncomment this and run. If they fix the issue in the later versions of @openshift-console/dynamic-plugin-sdk-webpack then we can remove this altogether. What do you think ?
There was a problem hiding this comment.
agreed, we can use this in local development and check for this in later versions of @openshift-console/dynamic-plugin-sdk-webpack
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anwesha-palit-redhat, arvindk-softwaredev The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b0fa093
into
openshift-pipelines:master
Dependency upgrades
@openshift/dynamic-plugin-sdk^4.0.0→^8.1.0,dynamic-plugin-sdk-extensions^1.3.0→^1.4.0,dynamic-plugin-sdk-utils^4.1.0→^5.0.1@patternfly/react-stylesandreact-routeras explicit dependencies (previously missing frompackage.json)eslint-plugin-react-hooks4.1.2→^4.6.0— adds eslint 8.x to its supported peer dependency rangestylelint-config-standard^31.0.0→^36.0.0— bumps its peer dep requirement tostylelint ^16.xi18next-parser^3.11.0→^9.3.0formik2.0.3→^2.1.5NODE_OPTIONSmax old space from 6144 to 4096 MBTypeScript fixes
nameValidationSchemaparameter type fromTFunctionto(key: string, options?: TOptions) => string— the function only callst(string), so requiring the full brandedTFunctiontype was unnecessarily strict and caused a type error when passing the plaintwrapper fromcommon-utilsTransinterpolation inRemoveTriggerFormandTriggerTemplateSelector— usei18nKey+values+componentsprops instead of object literal{{ varName }}children inside<b>tags, which are rejected by newer react-i18next TypeScript typesi18n pluralization fix
count→valueint()calls indetails-page.tsx,utils.ts,dateTime.ts, andevents.jsxwhere the number is used purely for interpolation, not for singular/plural variation.countis a reserved i18next keyword that triggers automatic plural key generation, causing CI failures wheni18next-parserv9 changed the plural format from_pluralto CLDR_one/_other