Skip to content

SRVKP-11123: Upgrade dependencies and resolve TypeScript, i18n and CI job issues#1001

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-pipelines:masterfrom
anwesha-palit-redhat:feat/SRVKP-11123
Mar 18, 2026
Merged

SRVKP-11123: Upgrade dependencies and resolve TypeScript, i18n and CI job issues#1001
openshift-merge-bot[bot] merged 1 commit intoopenshift-pipelines:masterfrom
anwesha-palit-redhat:feat/SRVKP-11123

Conversation

@anwesha-palit-redhat
Copy link
Contributor

@anwesha-palit-redhat anwesha-palit-redhat commented Mar 17, 2026

Dependency upgrades

  • Upgrade @openshift/dynamic-plugin-sdk ^4.0.0^8.1.0, dynamic-plugin-sdk-extensions ^1.3.0^1.4.0, dynamic-plugin-sdk-utils ^4.1.0^5.0.1
  • Add @patternfly/react-styles and react-router as explicit dependencies (previously missing from package.json)
  • Upgrade eslint-plugin-react-hooks 4.1.2^4.6.0 — adds eslint 8.x to its supported peer dependency range
  • Upgrade stylelint-config-standard ^31.0.0^36.0.0 — bumps its peer dep requirement to stylelint ^16.x
  • Upgrade i18next-parser ^3.11.0^9.3.0
  • Upgrade formik 2.0.3^2.1.5
  • Lower NODE_OPTIONS max old space from 6144 to 4096 MB

TypeScript fixes

  • Change nameValidationSchema parameter type from TFunction to (key: string, options?: TOptions) => string — the function only calls t(string), so requiring the full branded TFunction type was unnecessarily strict and caused a type error when passing the plain t wrapper from common-utils
  • Fix Trans interpolation in RemoveTriggerForm and TriggerTemplateSelector — use i18nKey + values + components props instead of object literal {{ varName }} children inside <b> tags, which are rejected by newer react-i18next TypeScript types

i18n pluralization fix

  • Rename countvalue in t() calls in details-page.tsx, utils.ts, dateTime.ts, and events.jsx where the number is used purely for interpolation, not for singular/plural variation. count is a reserved i18next keyword that triggers automatic plural key generation, causing CI failures when i18next-parser v9 changed the plural format from _plural to CLDR _one/_other
  • Update locale file to reflect the renamed interpolation keys

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 17, 2026

@anwesha-palit-redhat: This pull request references SRVKP-11123 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 17, 2026

@anwesha-palit-redhat: This pull request references SRVKP-11123 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 18, 2026

@anwesha-palit-redhat: This pull request references SRVKP-11123 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Dependency upgrades

  • Upgrade @openshift/dynamic-plugin-sdk ^4.0.0^8.1.0, dynamic-plugin-sdk-extensions ^1.3.0^1.4.0, dynamic-plugin-sdk-utils ^4.1.0^5.0.1
  • Add @patternfly/react-styles and react-router as explicit dependencies (previously missing from package.json)
  • Upgrade eslint-plugin-react-hooks 4.1.2^4.6.0 — adds eslint 8.x to its supported peer dependency range
  • Upgrade stylelint-config-standard ^31.0.0^36.0.0 — bumps its peer dep requirement to stylelint ^16.x
  • Upgrade i18next-parser ^3.11.0^9.3.0
  • Upgrade formik 2.0.3^2.1.5
  • Lower NODE_OPTIONS max old space from 6144 to 4096 MB

TypeScript fixes

  • Change nameValidationSchema parameter type from TFunction to (key: string, options?: TOptions) => string — the function only calls t(string), so requiring the full branded TFunction type was unnecessarily strict and caused a type error when passing the plain t wrapper from common-utils
  • Fix Trans interpolation in RemoveTriggerForm and TriggerTemplateSelector — use i18nKey + values + components props instead of object literal {{ varName }} children inside <b> tags, which are rejected by newer react-i18next TypeScript types

i18n pluralization fix

  • Rename countvalue in t() calls in details-page.tsx, utils.ts, dateTime.ts, and events.jsx where the number is used purely for interpolation, not for singular/plural variation. count is a reserved i18next keyword that triggers automatic plural key generation, causing CI failures when i18next-parser v9 changed the plural format from _plural to CLDR _one/_other
  • Update locale file to reflect the renamed interpolation keys

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anwesha-palit-redhat anwesha-palit-redhat changed the title SRVKP-11123: ci job for docker image is failing SRVKP-11123: Upgrade dependencies and resolve TypeScript, i18n and CI job issues Mar 18, 2026
// but doesn't skip hot-update assets, causing false-positive errors during HMR.
// afterEmit runs after the error is pushed (processAssets) but before done reports it.
{
/* {
Copy link
Contributor

@arvindk-softwaredev arvindk-softwaredev Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: will this affect HMR in local?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it will. It will fail with the same error we faced earlier, therefore I left the code and commented it, so that during dev we can uncomment this and run. If they fix the issue in the later versions of @openshift-console/dynamic-plugin-sdk-webpack then we can remove this altogether. What do you think ?

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, we can use this in local development and check for this in later versions of @openshift-console/dynamic-plugin-sdk-webpack

Copy link
Contributor

@arvindk-softwaredev arvindk-softwaredev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks Good to Me Label label Mar 18, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anwesha-palit-redhat, arvindk-softwaredev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [anwesha-palit-redhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b0fa093 into openshift-pipelines:master Mar 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Label for Approved PRs jira/valid-reference lgtm Looks Good to Me Label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants