Update google.golang.org/genproto digest to 3dc84a4#162
Update google.golang.org/genproto digest to 3dc84a4#162red-hat-konflux-kflux-prd-rh02[bot] wants to merge 1 commit into
Conversation
Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR updates a single transitive dependency in go.mod: the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: err: exit status 1: stderr: go: updates to go.mod needed, disabled by -mod=readonly; to update it:\n\tgo mod tidy\n" Comment |
|
Hi @red-hat-konflux-kflux-prd-rh02[bot]. Thanks for your PR. I'm waiting for a openshift-hyperfleet member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 138: The go.mod entry for the module symbol google.golang.org/genproto is
using a bare commit hash (3dc84a4a5aaa) which is invalid; replace that entry
with the canonical pseudo-version generated by the Go toolchain for that commit
(or a proper semver) by running go get/google module resolution (e.g., run `go
get google.golang.org/genproto@<commit>` or `go mod tidy`) to update the
dependency to the correct pseudo-version and commit mapping, then commit the
updated go.mod/go.sum.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 8e8d7bf5-0f4d-452e-b771-be2e9dbba997
📒 Files selected for processing (1)
go.mod
| golang.org/x/time v0.14.0 // indirect | ||
| google.golang.org/api v0.266.0 // indirect | ||
| google.golang.org/genproto v0.0.0-20260209200024-4cfbd4190f57 // indirect | ||
| google.golang.org/genproto 3dc84a4a5aaa // indirect |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Checking go.mod for non-canonical require versions (bare hashes)..."
rg -nP '^\s*[a-zA-Z0-9./_-]+\s+[0-9a-f]{7,40}\s*(//.*)?$' go.mod || true
echo
echo "Current genproto lines:"
rg -n 'google\.golang\.org/genproto' go.modRepository: openshift-hyperfleet/hyperfleet-sentinel
Length of output: 479
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "go.mod parser acceptance check:"
(go mod edit -print >/dev/null) && echo "go mod edit -print: OK" || echo "go mod edit -print: FAILED"
echo
echo "Module resolution/version check (may contact proxy):"
(go list -m -json google.golang.org/genproto >/dev/null) && echo "go list -m: OK" || echo "go list -m: FAILED"Repository: openshift-hyperfleet/hyperfleet-sentinel
Length of output: 446
Fix invalid go.mod dependency version for google.golang.org/genproto (line 138)
go mod rejects google.golang.org/genproto 3dc84a4a5aaa because the version is a bare hash; it must be a valid semver or canonical pseudo-version.
Suggested fix
- google.golang.org/genproto 3dc84a4a5aaa // indirect
+ google.golang.org/genproto v0.0.0-<timestamp>-<commit> // indirectUse the version produced by go get/go mod tidy for commit 3dc84a4a5aaa.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 138, The go.mod entry for the module symbol
google.golang.org/genproto is using a bare commit hash (3dc84a4a5aaa) which is
invalid; replace that entry with the canonical pseudo-version generated by the
Go toolchain for that commit (or a proper semver) by running go get/google
module resolution (e.g., run `go get google.golang.org/genproto@<commit>` or `go
mod tidy`) to update the dependency to the correct pseudo-version and commit
mapping, then commit the updated go.mod/go.sum.
This PR contains the following updates:
4cfbd41→3dc84a4Configuration
📅 Schedule: Branch creation - "on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.