Skip to content

Update google.golang.org/genproto digest to 3dc84a4#175

Open
red-hat-konflux-kflux-prd-rh02[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/google.golang.org-genproto-digest
Open

Update google.golang.org/genproto digest to 3dc84a4#175
red-hat-konflux-kflux-prd-rh02[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/google.golang.org-genproto-digest

Conversation

@red-hat-konflux-kflux-prd-rh02
Copy link
Copy Markdown
Contributor

@red-hat-konflux-kflux-prd-rh02 red-hat-konflux-kflux-prd-rh02 Bot commented Jun 1, 2026

This PR contains the following updates:

Package Type Update Change
google.golang.org/genproto indirect digest 0a33c5d3dc84a4

Configuration

📅 Schedule: Branch creation - "on monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
@red-hat-konflux-kflux-prd-rh02
Copy link
Copy Markdown
Contributor Author

ℹ️ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 6 additional dependencies were updated

Details:

Package Change
golang.org/x/text v0.35.0 -> v0.36.0
golang.org/x/crypto v0.49.0 -> v0.50.0
golang.org/x/net v0.52.0 -> v0.53.0
golang.org/x/sys v0.42.0 -> v0.43.0
golang.org/x/term v0.41.0 -> v0.42.0
google.golang.org/grpc v1.80.0 -> v1.81.1

@openshift-ci openshift-ci Bot requested review from Mischulee and vkareh June 1, 2026 04:13
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 1, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign aredenba-rh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 1, 2026

Hi @red-hat-konflux-kflux-prd-rh02[bot]. Thanks for your PR.

I'm waiting for a openshift-hyperfleet member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

📝 Walkthrough

Walkthrough

Updated Go module dependencies in go.mod: bumped golang.org/x/text from v0.35.0 to v0.36.0 in the direct require block. In the indirect dependencies, advanced golang.org/x/crypto, golang.org/x/net, golang.org/x/sys, golang.org/x/term, and google.golang.org/grpc to newer versions. No changes to module declarations or Go version itself.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning Title references google.golang.org/genproto digest update, but changeset also updates multiple other golang.org/x/* and google.golang.org/grpc dependencies. Update title to reflect all dependency updates or focus on the most significant change. Consider: 'Update Go module dependencies' or 'Update golang.org/x/* and google.golang.org/genproto dependencies'.
Description check ⚠️ Warning PR description mentions google.golang.org/genproto digest update, but raw_summary shows golang.org/x/* and google.golang.org/grpc updates with no mention of genproto. Verify actual changeset. Description appears to be auto-generated for a different PR or outdated. Update description to match the actual go.mod changes made.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Sec-02: Secrets In Log Output ✅ Passed Scanned all 539 log statements in non-test Go files; found 0 statements logging secrets, passwords, tokens, or credentials.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch konflux/mintmaker/main/google.golang.org-genproto-digest
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch konflux/mintmaker/main/google.golang.org-genproto-digest

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@go.mod`:
- Around line 176-178: The three genproto entries in go.mod are pinned to
different pseudo-versions which can cause module-resolution drift; update the
entries for google.golang.org/genproto/googleapis/api and
google.golang.org/genproto/googleapis/rpc to match the same pseudo-version used
for google.golang.org/genproto (3dc84a4a5aaa) or run a module convergence (e.g.,
use `go get google.golang.org/genproto@<same-pseudo-version>` or run `go mod
tidy` after aligning) so all genproto paths share the same release cohort and
avoid a split genproto module graph.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b45a0446-ed24-4ca3-aa95-7e1c923b076c

📥 Commits

Reviewing files that changed from the base of the PR and between f9a939a and 8430968.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum, !**/go.sum
📒 Files selected for processing (1)
  • go.mod

Comment thread go.mod
Comment on lines +176 to 178
google.golang.org/genproto v0.0.0-20260526163538-3dc84a4a5aaa // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20260523011958-0a33c5d7ca68 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20260523011958-0a33c5d7ca68 // indirect
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Read-only verification: detect mixed genproto pseudo-versions and impacted imports.
set -euo pipefail

echo "== genproto entries in go.mod =="
rg -n 'google\.golang\.org/genproto' go.mod

echo
echo "== genproto entries in go.sum (top 40) =="
rg -n '^google\.golang\.org/genproto' go.sum | head -n 40

echo
echo "== imports that may bind to these modules =="
rg -n --type=go 'google\.golang\.org/genproto|google\.golang\.org/grpc' -g '!**/*_test.go'

Repository: openshift-hyperfleet/hyperfleet-adapter

Length of output: 1600


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== go.mod grpc/genproto versions =="
rg -n '^google\.golang\.org/grpc v' go.mod || true
rg -n 'google\.golang\.org/genproto($|/googleapis/)' go.mod || true

echo
echo "== go.sum genproto/googleapis versions (unique counts) =="
rg -n '^google\.golang\.org/genproto(/googleapis/[^ ]+)? ' go.sum | wc -l
rg -n '^google\.golang\.org/genproto/googleapis/' go.sum | head -n 50

echo
echo "== non-test Go files importing genproto/genproto/googleapis =="
rg -n --no-heading --type go \
  'google\.golang\.org/(genproto|genproto/googleapis)/' \
  -g '!**/*_test.go' . || true

Repository: openshift-hyperfleet/hyperfleet-adapter

Length of output: 962


🏁 Script executed:

# Read-only verification (module coherence)
rg -n 'google\.golang\.org/genproto' go.mod
rg -n '^google\.golang\.org/genproto(/googleapis/[^ ]+)? ' go.sum | head -n 50
rg -n --no-heading --type go 'google\.golang\.org/(genproto|genproto/googleapis)/' -g '!**/*_test.go' . || true

Repository: openshift-hyperfleet/hyperfleet-adapter

Length of output: 1478


Align genproto and genproto/googleapis/* version pins in go.mod to avoid brittle module-resolution drift.

go.mod pins google.golang.org/genproto to 3dc84a4a5aaa, but keeps google.golang.org/genproto/googleapis/api and .../rpc on 0a33c5d7ca68. Align these to the same release cohort (or let go mod tidy converge) so transitive builds don’t end up with a split genproto module graph.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` around lines 176 - 178, The three genproto entries in go.mod are
pinned to different pseudo-versions which can cause module-resolution drift;
update the entries for google.golang.org/genproto/googleapis/api and
google.golang.org/genproto/googleapis/rpc to match the same pseudo-version used
for google.golang.org/genproto (3dc84a4a5aaa) or run a module convergence (e.g.,
use `go get google.golang.org/genproto@<same-pseudo-version>` or run `go mod
tidy` after aligning) so all genproto paths share the same release cohort and
avoid a split genproto module graph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants