Update google.golang.org/genproto digest to 3dc84a4#175
Update google.golang.org/genproto digest to 3dc84a4#175red-hat-konflux-kflux-prd-rh02[bot] wants to merge 1 commit into
Conversation
Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
ℹ️ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @red-hat-konflux-kflux-prd-rh02[bot]. Thanks for your PR. I'm waiting for a openshift-hyperfleet member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 WalkthroughWalkthroughUpdated Go module dependencies in Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Around line 176-178: The three genproto entries in go.mod are pinned to
different pseudo-versions which can cause module-resolution drift; update the
entries for google.golang.org/genproto/googleapis/api and
google.golang.org/genproto/googleapis/rpc to match the same pseudo-version used
for google.golang.org/genproto (3dc84a4a5aaa) or run a module convergence (e.g.,
use `go get google.golang.org/genproto@<same-pseudo-version>` or run `go mod
tidy` after aligning) so all genproto paths share the same release cohort and
avoid a split genproto module graph.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: b45a0446-ed24-4ca3-aa95-7e1c923b076c
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum,!**/go.sum
📒 Files selected for processing (1)
go.mod
| google.golang.org/genproto v0.0.0-20260526163538-3dc84a4a5aaa // indirect | ||
| google.golang.org/genproto/googleapis/api v0.0.0-20260523011958-0a33c5d7ca68 // indirect | ||
| google.golang.org/genproto/googleapis/rpc v0.0.0-20260523011958-0a33c5d7ca68 // indirect |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Read-only verification: detect mixed genproto pseudo-versions and impacted imports.
set -euo pipefail
echo "== genproto entries in go.mod =="
rg -n 'google\.golang\.org/genproto' go.mod
echo
echo "== genproto entries in go.sum (top 40) =="
rg -n '^google\.golang\.org/genproto' go.sum | head -n 40
echo
echo "== imports that may bind to these modules =="
rg -n --type=go 'google\.golang\.org/genproto|google\.golang\.org/grpc' -g '!**/*_test.go'Repository: openshift-hyperfleet/hyperfleet-adapter
Length of output: 1600
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== go.mod grpc/genproto versions =="
rg -n '^google\.golang\.org/grpc v' go.mod || true
rg -n 'google\.golang\.org/genproto($|/googleapis/)' go.mod || true
echo
echo "== go.sum genproto/googleapis versions (unique counts) =="
rg -n '^google\.golang\.org/genproto(/googleapis/[^ ]+)? ' go.sum | wc -l
rg -n '^google\.golang\.org/genproto/googleapis/' go.sum | head -n 50
echo
echo "== non-test Go files importing genproto/genproto/googleapis =="
rg -n --no-heading --type go \
'google\.golang\.org/(genproto|genproto/googleapis)/' \
-g '!**/*_test.go' . || trueRepository: openshift-hyperfleet/hyperfleet-adapter
Length of output: 962
🏁 Script executed:
# Read-only verification (module coherence)
rg -n 'google\.golang\.org/genproto' go.mod
rg -n '^google\.golang\.org/genproto(/googleapis/[^ ]+)? ' go.sum | head -n 50
rg -n --no-heading --type go 'google\.golang\.org/(genproto|genproto/googleapis)/' -g '!**/*_test.go' . || trueRepository: openshift-hyperfleet/hyperfleet-adapter
Length of output: 1478
Align genproto and genproto/googleapis/* version pins in go.mod to avoid brittle module-resolution drift.
go.mod pins google.golang.org/genproto to 3dc84a4a5aaa, but keeps google.golang.org/genproto/googleapis/api and .../rpc on 0a33c5d7ca68. Align these to the same release cohort (or let go mod tidy converge) so transitive builds don’t end up with a split genproto module graph.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` around lines 176 - 178, The three genproto entries in go.mod are
pinned to different pseudo-versions which can cause module-resolution drift;
update the entries for google.golang.org/genproto/googleapis/api and
google.golang.org/genproto/googleapis/rpc to match the same pseudo-version used
for google.golang.org/genproto (3dc84a4a5aaa) or run a module convergence (e.g.,
use `go get google.golang.org/genproto@<same-pseudo-version>` or run `go mod
tidy` after aligning) so all genproto paths share the same release cohort and
avoid a split genproto module graph.
This PR contains the following updates:
0a33c5d→3dc84a4Configuration
📅 Schedule: Branch creation - "on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.