Skip to content

Create 1.25 rhel 9.6 golang builder config#9815

Open
locriandev wants to merge 1 commit intoopenshift-eng:rhel-9-golang-1.25from
locriandev:1.25-to-9.6
Open

Create 1.25 rhel 9.6 golang builder config#9815
locriandev wants to merge 1 commit intoopenshift-eng:rhel-9-golang-1.25from
locriandev:1.25-to-9.6

Conversation

@locriandev
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@vfreex vfreex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2026
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 3, 2026

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from vfreex. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

set_build_variables: false
source:
path: images
dockerfile: openshift-golang-builder-rhel96.Dockerfile
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a new dockerfile?

Comment on lines +20 to +21
- rhel-9-golang-rpms
- rhel-97-golang-rpms
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should prefer one of these, so it's clear which repo we are sourcing golang rpms from


rhel-9-appstream-rpms:
conf:
baseurl:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i noticed a case where a newer golang build can come from appstream-rpms, we can define

extra_options:
        excludepkgs: golang*

enabled_repos:
- rhel-9-baseos-rpms
- rhel-9-golang-rpms
- rhel-97-golang-rpms
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think I removed this repo entry entirely in my previous change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants