openshift-5.0 [images]: convert openshift-enterprise-console to hermetic build#9719
Open
lgarciaaco wants to merge 1 commit intoopenshift-eng:openshift-5.0from
Open
Conversation
Remove network_mode: open override to enable default hermetic building. Clean up build modifications and artifacts that are no longer needed for hermetic builds including yarn artifact downloads and container modifications for cachito emulation mode. rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/hold for upstream PR |
openshift-ci
bot
added
the
do-not-merge/hold
lgarciaaco
force-pushed
the
hermetic/50-openshift-enterprise-console-dkgh
branch
from
3a044d3 to
05cf559
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
convert openshift-enterprise-console to hermetic build
Changes
Remove network_mode: open override to enable default hermetic building.
Clean up build modifications and artifacts that are no longer needed
for hermetic builds including yarn artifact downloads and container
modifications for cachito emulation mode.