Add thread-safe synchronization to startUpdatingOwnershipForShard#6426
Merged
graytaylor0 merged 1 commit intoopensearch-project:mainfrom Jan 23, 2026
Merged
Add thread-safe synchronization to startUpdatingOwnershipForShard#6426graytaylor0 merged 1 commit intoopensearch-project:mainfrom
graytaylor0 merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Divyansh Bokadia <[email protected]>
divbok
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
graytaylor0
approved these changes
Jan 23, 2026
san81
pushed a commit
to san81/data-prepper
that referenced
this pull request
Jan 27, 2026
…ensearch-project#6426) Signed-off-by: Divyansh Bokadia <[email protected]>
simonelbaz
pushed a commit
to simonelbaz/data-prepper
that referenced
this pull request
Jan 31, 2026
…ensearch-project#6426) Signed-off-by: Divyansh Bokadia <[email protected]> Signed-off-by: Simon ELBAZ <[email protected]>
simonelbaz
pushed a commit
to simonelbaz/data-prepper
that referenced
this pull request
Jan 31, 2026
…ensearch-project#6426) Signed-off-by: Divyansh Bokadia <[email protected]>
simonelbaz
pushed a commit
to simonelbaz/data-prepper
that referenced
this pull request
Jan 31, 2026
…ensearch-project#6426) Signed-off-by: Divyansh Bokadia <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a race condition in ShardAcknowledgementManager when shards repeatedly receive negative acks.
The Race Condition:
When a shard receives a negative ack, the ShardAcknowledgementManager removes it from checkpoints and gives up the partition. The StreamScheduler immediately re-acquires it and creates a new consumer. Without synchronization, the new consumer's
startUpdatingOwnershipForShard()(adding the shard to checkpoints) can execute concurrently with the ShardAcknowledgementManagerremovePartitions()(removing the shard from checkpoints) causing the shard to go in an inconsistent/zombie state where it might lead to scenarios where the checkPointStatuses queue is empty for the shardCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.