[Backport 2.19] Fix map_unmapped_fields_as_text lost after dynamic mapping update#21309
[Backport 2.19] Fix map_unmapped_fields_as_text lost after dynamic mapping update#21309opensearch-trigger-bot[bot] wants to merge 2 commits into2.19from
Conversation
…1301) When a dynamic mapping update triggers a mapping merge, the PercolatorFieldMapper is rebuilt via ParametrizedFieldMapper.merge() which passes Settings.EMPTY to BuilderContext. The Builder read map_unmapped_fields_as_text from these empty settings, reverting it to the default value of false. Preserve the setting value through merges by passing it from the existing mapper into the new Builder instance. Closes #21072 Signed-off-by: Andrew Ross <[email protected]> (cherry picked from commit 7c40edb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
❌ Gradle check result for 7bc1ad0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…s on 2.19 The createIndexWithSimpleMappings method does not exist on the 2.19 branch. Use the existing createIndex(String, Settings, String, String...) method instead, which takes the type name as the third argument. Signed-off-by: Andrew Ross <[email protected]>
|
❌ Gradle check result for c00074c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for c00074c: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.19 #21309 +/- ##
============================================
+ Coverage 71.92% 72.06% +0.13%
+ Complexity 66009 64508 -1501
============================================
Files 5342 5122 -220
Lines 307392 300239 -7153
Branches 44862 44091 -771
============================================
- Hits 221105 216362 -4743
+ Misses 67823 65766 -2057
+ Partials 18464 18111 -353 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
Backport 7c40edb from #21301.