[Draft] Create a new Iceberg Catalog Plugin for exporting data to S3 tables#21284
Conversation
…iceberg catalog Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
PR Code Analyzer ❗AI-powered 'Code-Diff-Analyzer' found issues on commit 890194a.
The table above displays the top 10 most important findings. Pull Requests Author(s): Please update your Pull Request according to the report above. Repository Maintainer(s): You can Thanks. |
Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
rajiv-kv
left a comment
rajiv-kv
left a comment
There was a problem hiding this comment.
Can you check the failing build. Looks like diff_analyzer is flagging the checked-in jar.
| * compatible open source license. | ||
| */ | ||
|
|
||
| package org.opensearch.plugin.iceberg.catalog; |
There was a problem hiding this comment.
can the package be named as org.opensearch.plugin.catalog.iceberg
| * OpenSearch index data to S3 Tables. It copies S3 client code from repository-s3 | ||
| * for plugin isolation (plugins cannot depend on other plugins). | ||
| */ | ||
| public class IcebergMetadataCatalogPlugin extends Plugin {} |
There was a problem hiding this comment.
- Lets name it as IcebergCatalogPlugin.
- I believe you will define interface CatalogPlugin in core ?
There was a problem hiding this comment.
done. Yes, will raise that in following PR
There was a problem hiding this comment.
I'm all for starting small, but I'd recommend starting with the new catalog plugin abstraction and don't create a plugin until there is something from it to use. No one can provide a meaningful review of this code because it doesn't do anything and there's no description about what it is intended to do beyond "integrate with iceberg metadata"
Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
Enabled third party audit and severity went from critical to high. I believe that the action is configured to flag any jar being checked in to the code |
Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
| } | ||
| } | ||
|
|
||
| // Disable checks that are not relevant for this initial scaffold. |
There was a problem hiding this comment.
Why are these not relevant? This is bypassing the checks intended to verify that the new dependencies you're bringing in are of a compatible license.
sachin-27
changed the title
3 participants
Description
Creates a new plugin which enables opensearch to integrate with iceberg metadata. Includes files and dependencies required to connect to S3
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.