Reuse C# RPC process across CSharpRecipeTest methods#7332
Merged
steve-aom-elliott merged 1 commit intomainfrom Apr 9, 2026
Merged
Reuse C# RPC process across CSharpRecipeTest methods#7332steve-aom-elliott merged 1 commit intomainfrom
steve-aom-elliott merged 1 commit intomainfrom
Conversation
Each test was shutting down and restarting the dotnet process, paying the full cost of process startup + NuGet restore + JIT warmup every time. On slow CI runners this can push individual tests past the 60-second RPC timeout, causing flaky failures. Switch @AfterEach to resetCurrent() (clears RPC state, keeps process alive) and add @afterall to shut down the process when the class is done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CSharpRecipeTestwas shutting down and restarting the dotnet RPC process after every test method, paying the full cost of process startup + NuGet restore + JIT warmup each timedeleteMethodArgumentfailures@AfterEachfromshutdownCurrent()toresetCurrent()(clears RPC state without killing the process) and add@AfterAllto shut down when the class is doneTest plan
CSharpRecipeTest.deleteMethodArgumentno longer times out on slow runners