C#: Fix SearchResult.Found using dynamic dispatch instead of reflection#7319
Draft
steve-aom-elliott wants to merge 2 commits intomainfrom
Draft
C#: Fix SearchResult.Found using dynamic dispatch instead of reflection#7319steve-aom-elliott wants to merge 2 commits intomainfrom
steve-aom-elliott wants to merge 2 commits intomainfrom
Conversation
steve-aom-elliott
force-pushed
the
fix/csharp-tree-withmarkers
branch
from
e9d9c4e to
c2e3ff4
Compare
steve-aom-elliott
changed the title
SearchResult.Found used GetMethod reflection to call WithMarkers on concrete tree types. This silently returned the same instance when GetMethod failed, breaking PreconditionsCheckTest assertions that were previously masked by Gradle build cache. Replace the fragile reflection with dynamic dispatch, which reliably resolves WithMarkers on any concrete type at runtime.
ExpressionStatement delegates Markers to its inner expression but had no WithMarkers method, which would cause a RuntimeBinderException if SearchResult.Found or any other dynamic WithMarkers call targeted this type.
steve-aom-elliott
force-pushed
the
fix/csharp-tree-withmarkers
branch
from
27f81c1 to
be46a4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetMethodreflection inSearchResult.Found<T>()withdynamicdispatchThe original code used
tree.GetType().GetMethod("WithMarkers", ...)which silently returnednull, causingFoundto return the same tree instance unchanged. Dynamic dispatch reliably resolvesWithMarkerson any concrete type at runtime.Context
Two
PreconditionsCheckTesttests have been failing on main since 71809c7 invalidated the Gradle build cache, causingcsharpTestto actually execute for the first time:CheckDelegatesToVisitorWhenPreconditionMatches—Assert.NotSame()failure (same object returned)PreconditionMatchesAndVisitorRuns— "Recipe was expected to make changes" (no marker added)These tests were never caught earlier because
:rewrite-csharp:csharpTestwasFROM-CACHEin CI.Test plan
PreconditionsCheckTesttests pass locally (including both previously failing):rewrite-csharp:csharpTest