Allow AddMethodParameter to match overridden methods - #6294
Merged
Conversation
Anmol202005
force-pushed
the
addParam
branch
from
November 14, 2025 18:26
2bf9aeb to
813940a
Compare
Contributor
Author
|
@timtebeek kindly review :) |
timtebeek
self-requested a review
November 14, 2025 18:50
Member
|
Thanks for the runnable example! I'm off here today, but will try to circle back next week. I had thought we could clear this up with just changing the expected method pattern instead. |
Contributor
Author
|
ping @timtebeek |
Member
|
Will likely move into next week before I can get to this; I've got some online trainings to give and a weekend ahead first. 🙏🏻 |
timtebeek
approved these changes
Dec 24, 2025
timtebeek
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for the help here @Anmol202005 ! Found a way to achieve the same without changes to MethodMatcher, to minimize added API surface and potential impact. With that I think we're ok to merge this change.
Appreciate your patience as well; it's not been easy to get to everything, but hope you enjoy some end of year time off there!
AddMethodParameter to match overridden methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves AddMethodParameter so that methodPattern resolution includes overridden methods from interfaces and superclasses.
AddMethodParameterto operate on overridden methods #6287Checklist