Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
==========================================
+ Coverage 86.57% 86.70% +0.13%
==========================================
Files 73 67 -6
Lines 1564 1467 -97
==========================================
- Hits 1354 1272 -82
+ Misses 210 195 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
davidbeig
left a comment
davidbeig
left a comment
There was a problem hiding this comment.
Hi @ElviaBth !
When generating the development_app i find some errors that you have to take a look at:
- Faker::Twitter is removed from the Faker gem. This is due to the upgrade to the 3.6.0. Also, the change is backported to the 0.31.1, i believe.
- In the seed process there are some errors because the UserGroup no longer exists for the 0.31 too.
- Check also the failing tests.
I will continue to review it, but you can start with these changes!
Thanks! <3
|
Hello @davidbeig, I applied the suggested changes. Can you re-check? Btw, all specs passed on my local, but here on GitHub, two of them keep failing. |
davidbeig
left a comment
davidbeig
left a comment
There was a problem hiding this comment.
Can you do the changes about the migration?
Also, i don't know why, but locally i get some errors related to other specs than the ones of the GHAction.
Since there are no db/migrations right now, the test_app creation fails for me. Can you test that also?
I have prepared changes in the README.md that i will publish now also, and there are some wrong things in the admin list of the reporting_proposals component. I also have some fixes for that.
Thanks again @ElviaBth !
| # frozen_string_literal: true | ||
|
|
||
| class CreateDecidimCategoriesValuators < ActiveRecord::Migration[6.0] | ||
| def change | ||
| create_table :decidim_reporting_proposals_category_valuators do |t| | ||
| t.references :decidim_category, null: false, foreign_key: { to_table: "decidim_categories" }, index: { name: "decidim_reporting_proposals_category_category_id" } | ||
| t.references :valuator_role, polymorphic: true, null: false, index: { name: "decidim_reporting_proposals_category_valuator_role" } | ||
|
|
||
| t.timestamps | ||
| end | ||
|
|
||
| add_index :decidim_reporting_proposals_category_valuators, | ||
| [:decidim_category_id, :valuator_role_id, :valuator_role_type], | ||
| unique: true, | ||
| name: "decidim_reporting_proposals_category_valuator_unique" | ||
| end | ||
| end |
There was a problem hiding this comment.
I don't think we should remove a migration... Maybe we can add a new migration to remove the table, or whatever, but with this it would stay in the database for ever.
I think it's better to create a new one.
There was a problem hiding this comment.
Hi @davidbeig, good catch, thanks! I'll add a new migration to drop the table instead of removing the existing one. That way, we keep the full database change history.
|
For the test_app, try running |
2 participants
🎩 What? Why?
This PR upgrades to Decidim version 0.31
📌 Related Issues
Link your PR to an issue
Related to #?
Fixes #114
📷 Screenshots