fix: add enabled condition check for collector agent and gateway (#165)#188
Open
wang4150 wants to merge 1 commit intoopenobserve:mainfrom
Open
fix: add enabled condition check for collector agent and gateway (#165)#188wang4150 wants to merge 1 commit intoopenobserve:mainfrom
wang4150 wants to merge 1 commit intoopenobserve:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
Fixes #165 - The
agent.enabledandgateway.enabledsettings in values.yaml have no effect. Agent DaemonSet and Gateway are always created regardless of the values set.Changes
{{- if .Values.agent.enabled }}conditional check inagent.yamltemplate{{- if .Values.gateway.enabled }}conditional check ingateway.yamltemplateImpact