Escape HTML inn Process of creating patient to avoid XSS#208
Open
slubwama wants to merge 1 commit intoopenmrs:masterfrom
Open
Escape HTML inn Process of creating patient to avoid XSS#208slubwama wants to merge 1 commit intoopenmrs:masterfrom
slubwama wants to merge 1 commit intoopenmrs:masterfrom
Conversation
Member
|
@slubwama were you able to reproduce the problem that was reported of doing this without going through the UI? |
Contributor
Author
@dkayiwa given time. Yes Got the tool still trying to learn how to use it to replicate the error. But from the look of things basing on the comments Its caused as a results of not escaping the attributes items in patient object |
Member
|
@slubwama this time round, i do not feel comfortable merging pull requests, if we cannot first of all reproduce the problem and then afterwords confirm that with the changes in the pull request, the same exact steps can no longer reproduce the reported problem. Do i make sense? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.