(fix) O3-5479: Implement safe patient display parsing with validation and fallbacks

[omeriinnocent]

Requirements

• This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.
• My work is based on designs, which are linked or shown either in the Jira ticket or the description below.
• My work includes tests or is validated by existing tests.

Summary

The mapBillProperties function splits patient.display on plain -, which breaks when the identifier or name contains hyphens. It also returns undefined when the display string is missing or has no separator, causing patient names to render as "undefined" in bills and invoices.

This PR extracts a parsePatientDisplay helper that:

• Uses - (space-hyphen-space) as the delimiter, matching the format returned by the REST API
• Takes everything after the first separator as the name, preserving names with additional hyphens
• Returns empty strings instead of undefined when the display string is missing or has no separator
• Trims whitespace from both identifier and name

Screenshots

Related Issue

https://openmrs.atlassian.net/browse/O3-5479

Other

[omeriinnocent]

@ELVIS-KATO ,help review this

[ELVIS-KATO]

Thanks @omeriinnocent for the fix. The changes address the ticket and the functionality looks good.
One small request: the additional comments added in the code are not necessary in this case. Since the code is already clear and self-explanatory, it would be better to remove them to keep the codebase clean and consistent.

So could you please remove those comments?

[omeriinnocent]

Thanks @ELVIS-KATO ,

[omeriinnocent]

hi @denniskigen ,can you have a look at this?

[ELVIS-KATO]

LGTM @denniskigen @VeronicaMuthee

[NethmiRodrigo]

Isn’t the hyphenated display the default way in OpenMRS and not likely to change? @dkayiwa @denniskigen

[EDSONZ-WASSWA]

Isn’t the hyphenated display the default way in OpenMRS and not likely to change? @dkayiwa @denniskigen

@NethmiRodrigo I think keeping them doesn't hurt because it's defensive against issues like corrupted data, and maybe future schema changes or third-party system integration

[denniskigen]

Thanks for looking into this, @omeriinnocent! Displaying undefined in the UI is definitely a bug worth fixing.

I checked the backend: BillResource exposes patient as Representation.REF, and the patient display comes from the REST module's patient resource getter, which formats it as IDENTIFIER - Given Family using - as the delimiter.

See inline comments for details. This would also benefit from a few unit tests for the parsing function — null input, standard format, hyphenated identifier, no hyphen, etc.

[omeriinnocent]

thanks @ELVIS-KATO , @EDSONZ-WASSWA for the review feedback,

[omeriinnocent]

Hi @denniskigen ,Thanks for the detailed feedback. I’ve addressed the comments and updated the implementation accordingly:
Refactored the safe patient display parsing to make it more robust. I added validation logic to ensure consistent data handling and introduced fallback mechanisms to gracefully handle unexpected or malformed input.
Test Updates:
Updated existing unit tests to align with the new logic and added additional test cases to cover edge scenarios, including validation and fallback behavior.

These changes aim to fully address the concerns you raised and improve overall reliability.
Please take another look when you have time — happy to make further adjustments if needed.

[denniskigen]

LGTM. Thanks, @omeriinnocent!

[omeriinnocent]

wooh,thanks for your time @denniskigen