Feat: Add quorum support to rabbitmq driver#66
Open
Chr1s70ph wants to merge 11 commits intoopenmessaging:masterfrom
Open
Feat: Add quorum support to rabbitmq driver#66Chr1s70ph wants to merge 11 commits intoopenmessaging:masterfrom
Chr1s70ph wants to merge 11 commits intoopenmessaging:masterfrom
Conversation
fix: database might still hold data after a restart fix: driver did not work with docker environment fix: epmd not running, so rabbitmq could not start chore: refactor for better readability chore: update rabbitmq version to 4.2.3
the current implementation did simply not work.
update nodes to represent docker hosts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR includes:
Adds quorum support to the rabbitmq-driver.
Though already partially implemented, the current implementation did have some major bugs, which prevented it from working.
Fixes old docker environment
The Debian stretch repositories are no longer online and thus the docker containers can no longer install packages. Updating to Debian sid is the only option, since its the only version that still has the
openjdk-8-jdkin their repositories by default.Implements delivery time measurements
The data from the rabbitmq tests was incomparable to the other drivers results, since it did not include a response time from the server, simply the time it took to send a message. Weather that package was actually received or even left the host was not checked and thus did yield incorrect results.
Fixes some style tests
When running
mvn clean installthere were some small issues with coding style (namely variable naming), which have also been fixed in this PR.Skipped the SSH test
In the SSH test, there is a hard coded IP address as well as hard coded credentials. This test does not work, since the host is no longer reachable. Since I deemed it out of scope for this PR to fix this test I just disabled it for this PR.