8367408: [lworld] runtime/cds/appcds/methodHandles/MethodHandlesGeneralTest.java#aot fails

[coleenp]

This test has failed for various reasons, but the last of the reasons was that sig_cc - calling convention adapter for scalarized parameters was null for a value class. The sig_cc adapter for valhalla won't be saved with AOT until JDK-8373348. This change moves where they are regenerated to where the method is linked.

Testing with tier1-4. in progress, and with the failed test.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8367408: [lworld] runtime/cds/appcds/methodHandles/MethodHandlesGeneralTest.java#aot fails (Bug - P4)

Reviewers

• Matias Saavedra Silva (@matias9927 - Committer) ⚠️ Review applies to d3ae06c4
• Frederic Parain (@fparain - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1837/head:pull/1837
$ git checkout pull/1837

Update a local copy of the PR:
$ git checkout pull/1837
$ git pull https://git.openjdk.org/valhalla.git pull/1837/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1837

View PR using the GUI difftool:
$ git pr show -t 1837

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1837.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367408: [lworld] runtime/cds/appcds/methodHandles/MethodHandlesGeneralTest.java#aot fails

Reviewed-by: matsaave, fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 02: Full - Incremental (f8c23ab7)
• 01: Full (7c16d8df)
• 00: Full (d3ae06c4)

[matias9927]

Thanks for fixing this, looks good!

[openjdk]

@coleenp this pull request can not be integrated into lworld due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout method-handles
git fetch https://git.openjdk.org/valhalla.git lworld
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld"
git push

[coleenp]

Thanks Matias for reviewing.

[fparain]

LGTM

[coleenp]

Thank you for the reviews Matias and Fred.
/integrate

[openjdk]

Going to push as commit fe500a0.
Since your change was applied there have been 4 commits pushed to the lworld branch:

• f682e44: 8368799: [lworld] Heapwalking functions may report array classes several times
• 423e693: 8373987: [lworld] exploded-image/test broken since disable patching (JDK-8373806)
• 27a8cbe: 8374016: [lworld] Too late checked_cast in ResolvedFieldEntry::set_flags
• ... and 1 more: https://git.openjdk.org/valhalla/compare/4b318c818597a6e53812de95bdcc4fbdc0a10793...lworld

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit fe500a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.